You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by dustin vanstee <du...@gmail.com> on 2017/05/08 01:29:32 UTC

Mahout-1962

Hi Trevor, for your awareness I posted a pull request for Mahout-1962.
Couple of notes regarding that PR

I think the model.summary is better to have consolidated in the
generateSummaryString function rather than spread around in all the
functions.  one reason is that the model.summary changes depending on the
order you call the functions, and the other is that have the summary code
distributed all over the place is hard to follow.  if its in just one spot,
its easy to control.

The other thing is the initialization of rss to -9999.  i am doing that so
that the first time the rss function gets called it will actually calculate
something ,and then anytime thereafter it wont.  i am just checking to see
if rss > 0.   maybe there is a more elegant way, but not sure ….

I addressed all your other recommendations from the github pull request.
 thanks!