You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/15 08:04:54 UTC

[GitHub] [apisix] avinal commented on a change in pull request #6610: docs: move keyword definition to `Terminology` section and improve

avinal commented on a change in pull request #6610:
URL: https://github.com/apache/apisix/pull/6610#discussion_r826680583



##########
File path: docs/en/latest/architecture-design/debug-mode.md
##########
@@ -63,10 +63,10 @@ The checker would only check this if the file was updated by checking its last m
 | Key                             | Optional | Description                                                                                                                               | Default |
 | ------------------------------- | -------- | ----------------------------------------------------------------------------------------------------------------------------------------- | ------- |
 | hook_conf.enable                | required | Enable/Disable hook debug trace. Target module function's input arguments or returned value would be printed once this option is enabled. | false   |
-| hook_conf.name                  | required | The module list name of the hook which has enabled debug trace.                                                                               |         |
-| hook_conf.log_level             | required | Logging levels for input arguments & returned values.                                                                                      | warn    |
-| hook_conf.is_print_input_args   | required | Enable/Disable printing input arguments.                                                                                                     | true    |
-| hook_conf.is_print_return_value | required | Enable/Disable printing returned values.                                                                                                      | true    |
+| hook_conf.name                  | required | The module list name of the hook which has enabled debug trace.                                                                           |         |
+| hook_conf.log_level             | required | Logging levels for input arguments & returned values.                                                                                     | warn    |
+| hook_conf.is_print_input_args   | required | Enable/Disable printing input arguments.                                                                                                  | true    |
+| hook_conf.is_print_return_value | required | Enable/Disable printing returned values.                                                                                                  | true    |

Review comment:
       I think this is just reformatted, removed tabs and instead used spaces, a precaution for indentation-sensitive languages. Tabs and spaces are often mixed and can cause issues, so it is preferred to use spaces everywhere until otherwise needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org