You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/04/10 01:40:09 UTC

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64 

zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15705


Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/util/blocking-queue.h
2 files changed, 15 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5986/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 10:21:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/exec/hdfs-scanner.h
M be/src/util/aligned-new.h
M be/src/util/blocking-queue.h
4 files changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/8
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h
File be/src/util/blocking-queue.h:

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@82
PS4, Line 82:         offsetof(BlockingQueue, get_lock_) / 64);
> Is this change necessary after you added the padding? It seems like they sh
Hi, Tim, you are right, it is not necessary, I already remove it.



-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 09:02:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5789/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Apr 2020 01:58:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6004/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 02:39:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 12:

Thanks for the contribution!


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 04:18:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5826/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Apr 2020 09:00:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5855/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 09:43:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5847/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 17:49:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/util/blocking-queue.h
2 files changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 20:44:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 7:

Hi, Tim, this has been fixed as your request


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 09:30:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6037/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 04:38:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/exec/hdfs-scanner.h
M be/src/util/aligned-new.h
M be/src/util/blocking-queue.h
4 files changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5780/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Apr 2020 02:22:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h
File be/src/common/compiler-util.h:

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h@21
PS4, Line 21: #include "gutil/port.h"
Instead of pulling another header in here, which pulls in more transitive dependencies, the locations that use CACHELINE_SIZE should just include gutil/port.h directly.


http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h
File be/src/util/blocking-queue.h:

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@79
PS4, Line 79:     // On aarch64 platform, size of mutex is 48, this DCHECK_NE will fail,
Nit: reformat comment to fit on 2 lines


http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@81
PS4, Line 81: aglined
nit: aligned


http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/util/blocking-queue.h@82
PS4, Line 82: #ifndef __aarch64__
Is this change necessary after you added the padding? It seems like they should be separated now



-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 17:57:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 4:

(1 comment)

SOrry for the slow turnaround on the review

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h
File be/src/common/compiler-util.h:

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h@21
PS4, Line 21: #include "gutil/port.h"
> Hi, Tim, except the blocking-queue.h, there are also other files use this C
Yep, that would be great



-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 May 2020 18:27:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/exec/hdfs-scanner.h
M be/src/util/aligned-new.h
M be/src/util/blocking-queue.h
4 files changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/9
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 11: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 02:03:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/exec/hdfs-scanner.h
M be/src/util/aligned-new.h
M be/src/util/blocking-queue.h
4 files changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/10
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/util/blocking-queue.h
2 files changed, 15 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5824/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 20:45:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/util/blocking-queue.h
2 files changed, 15 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Reviewed-on: http://gerrit.cloudera.org:8080/15705
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/compiler-util.h
M be/src/exec/hdfs-scanner.h
M be/src/util/aligned-new.h
M be/src/util/blocking-queue.h
4 files changed, 13 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................

IMPALA-9630 Keep blocking queue cache line aligned on aarch64

On aarch64, the DNCHECK_NE in BlockingQueue construct function
 will fail. So here use a different method to keep the 'put'
 class members and 'get' class members cache line aligned.

Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
---
M be/src/common/compiler-util.h
M be/src/util/blocking-queue.h
2 files changed, 15 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/15705/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 20:45:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h
File be/src/common/compiler-util.h:

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h@21
PS4, Line 21: #include "gutil/port.h"
> Instead of pulling another header in here, which pulls in more transitive d
Hi, Tim, except the blocking-queue.h, there are also other files use this CACHE_LINE_SIZE, such as aligned-new.h and hdfs-scanner.h, do you want me change them all to use CACHELINE_SIZE in gutil/port.h?



-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 08:40:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6018/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 02:54:53 +0000
Gerrit-HasComments: No