You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/19 12:40:15 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #37220: [SPARK-39810][SQL] tableExists wrongly assumes input only has 3 name parts
LuciferYang commented on code in PR #37220:
URL: https://github.com/apache/spark/pull/37220#discussion_r924451531
##########
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala:
##########
@@ -767,6 +767,13 @@ class CatalogSuite extends SharedSparkSession with AnalysisTest with BeforeAndAf
Map.empty[String, String], "")
assert(spark.catalog.tableExists(Array(catalogName, dbName, tableName).mkString(".")))
+
+ val dbName2 = "my_db2.my_db3"
Review Comment:
I think we should make it an independent test and name it with `SPARK-39810:` as the prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org