You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2024/09/15 01:05:55 UTC

[I] Bump lexical-core to 1.0 [arrow-rs]

Jefffrey opened a new issue, #6397:
URL: https://github.com/apache/arrow-rs/issues/6397

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   `lexical-core` is currently being used for JSON, CSV and cast:
   
   https://github.com/apache/arrow-rs/blob/ba85fa3bc68fd6fdc2b401adcf5eddb9f482b7c9/arrow-json/Cargo.toml#L48
   
   https://github.com/apache/arrow-rs/blob/ba85fa3bc68fd6fdc2b401adcf5eddb9f482b7c9/arrow-csv/Cargo.toml#L46
   
   https://github.com/apache/arrow-rs/blob/ba85fa3bc68fd6fdc2b401adcf5eddb9f482b7c9/arrow-cast/Cargo.toml#L52
   
   A `1.0.0` release is out now, which fixes some soundness issues.
   
   According to [the reddit post](https://www.reddit.com/r/rust/comments/1fgyopo/lexicalcore_version_100_released_major_security/
   ), pre `1.0.0` versions will be yanked soon.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   Bump to `lexical-core=1.0.0`
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   This issue may become redundant: https://github.com/apache/arrow-rs/issues/5422
   
   We also switched to `atoi` in this PR for arrow-cast: https://github.com/apache/arrow-rs/pull/5398. Could see if it's worth switching back to lexical-core, if can confirm the correctness issues are resolved and if performance might benefit (otherwise can stay as is).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Bump lexical-core to 1.0 [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #6397: Bump lexical-core to 1.0
URL: https://github.com/apache/arrow-rs/issues/6397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org