[GitHub] [iceberg] rdblue commented on a diff in pull request #6346: Python: Fix PyArrow Type conversion

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6346:
URL: https://github.com/apache/iceberg/pull/6346#discussion_r1038336833


##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -387,6 +388,12 @@ def _(_: BinaryType) -> pa.DataType:
     return pa.binary()
 
 
+def _convert_scalar(value: Any, iceberg_type: IcebergType) -> pa.scalar:
+    if not isinstance(iceberg_type, PrimitiveType):

Review Comment:
   Why isn't this necessary for `In` and `NotIn`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org