[GitHub] storm pull request #2440: STORM-2784: storm-kafka-client KafkaTupleListener ...

[hmcl <gi...@git.apache.org>]

GitHub user hmcl opened a pull request:

    https://github.com/apache/storm/pull/2440

    STORM-2784: storm-kafka-client KafkaTupleListener method onPartitionsReassigned() should be called after initialization is complete

    Somehow this change got reverted during a merge in 1.x-branch. It is fine in master, so we should just merge this patch here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hmcl/storm-apache 1.x-branch_STORM-2784_KTLOPR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2440
    
----
commit 472a0ad79701158bce8a27bf794d5687a537048d
Author: Hugo Louro <hm...@gmail.com>
Date:   2017-10-23T04:35:29Z

    STORM-2784: storm-kafka-client KafkaTupleListener method onPartitionsReassigned() should be called after initialization is complete

----


---

[GitHub] storm issue #2440: STORM-2784: storm-kafka-client KafkaTupleListener method ...

[srdo <gi...@git.apache.org>]

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2440
  
    +1, nice catch


---

[GitHub] storm issue #2440: STORM-2784: storm-kafka-client KafkaTupleListener method ...

[HeartSaVioR <gi...@git.apache.org>]

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2440
  
    Thanks @hmcl I merged this into 1.x-branch again.


---

[GitHub] storm pull request #2440: STORM-2784: storm-kafka-client KafkaTupleListener ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2440


---