[GitHub] [incubator-druid] gianm commented on a change in pull request #7256: fix SequenceMetadata deserialization

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #7256: fix SequenceMetadata deserialization
URL: https://github.com/apache/incubator-druid/pull/7256#discussion_r265169753
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
 ##########
 @@ -508,6 +504,7 @@ public void run()
             if (isEndSequenceOffsetsExclusive() &&
                 createSequenceNumber(record.getSequenceNumber()).compareTo(
                     createSequenceNumber(endOffsets.get(record.getPartitionId()))) >= 0) {
+              stillReading = false;
 
 Review comment:
   `stillReading` should only be set to `false` when our assignment is empty (no partitions left to read). Hitting the end offset for one partition doesn't mean we should stop reading _all_ partitions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org