You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 13:57:58 UTC

[GitHub] [airflow] yuqian90 commented on pull request #13037: Add a "Resume" option to Mark Success to automatically resume blocked tasks after marking success

yuqian90 commented on pull request #13037:
URL: https://github.com/apache/airflow/pull/13037#issuecomment-757968126


   > @yuqian90 I think this button can also apply to Mark Failed.
   > If the downstream task has trigger rule of one_failed / all_failed etc
   
   @RosterIn  This is now done. Marking Success/Failed will both clear downstream tasks in failed/upstream_failed state.
   
   
   
   > I certainly can't think of one, 1 sounds good to me.
   > 
   > Question: does the (new) API use the same code path? Perhaps this could be a case where the API could have the parameter, but the UI is kept simpler.
   
   HI @ash I went with option 1. The PR now looks much simpler. Please take another look. I have not looked into the API. It's not using the code path in views.py as far as I can tell. I think API changes can be done separately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org