You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/03/26 13:50:45 UTC

[commons-csv] branch master updated: [CSV-149] Add disabled test.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git


The following commit(s) were added to refs/heads/master by this push:
     new 96b8485  [CSV-149] Add disabled test.
96b8485 is described below

commit 96b8485176fab410d6ff829e7e9b6b5f817671ab
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Mar 26 09:50:40 2020 -0400

    [CSV-149] Add disabled test.
---
 .../apache/commons/csv/issues/JiraCsv149Test.java  | 57 ++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv149Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv149Test.java
new file mode 100644
index 0000000..0a59c70
--- /dev/null
+++ b/src/test/java/org/apache/commons/csv/issues/JiraCsv149Test.java
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+@Disabled
+public class JiraCsv149Test {
+
+    @Test
+    public void testJiraCsv149EndWithEOL() throws IOException {
+        testJiraCsv149EndWithEolAtEof(true);
+    }
+
+    private void testJiraCsv149EndWithEolAtEof(boolean eolAtEof) throws IOException {
+        String source = "A,B,C,D\r\n" + "a1,b1,c1,d1\r\n" + "a2,b2,c2,d2";
+        if (eolAtEof) {
+            source += "\\r\\n";
+        }
+        final StringReader records = new StringReader(source);
+        final CSVFormat format = CSVFormat.RFC4180.withFirstRecordAsHeader().withQuote('"');
+        int lineCounter = 2;
+        try (final CSVParser parser = new CSVParser(records, format)) {
+            for (CSVRecord record : parser) {
+                assertEquals(lineCounter++, parser.getCurrentLineNumber());
+            }
+        }
+    }
+
+    @Test
+    public void testJiraCsv149EndWithoutEOL() throws IOException {
+        testJiraCsv149EndWithEolAtEof(false);
+    }
+}