[GitHub] [iceberg] pvary commented on a change in pull request #1850: Hive: fix hiveCatalog create/write table and hive client read no data

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1850:
URL: https://github.com/apache/iceberg/pull/1850#discussion_r532578594



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -366,20 +370,27 @@ static void validateTableIsIceberg(Table table, String fullName) {
    * The decision is made like this:
    * <ol>
    * <li>Table property value {@link TableProperties#ENGINE_HIVE_ENABLED}
-   * <li>If the table property is not set then check the hive-site.xml property value
+   * <li>If the table property is not set then check hive metastore TABLE_PARAMS value
    * {@link ConfigProperties#ENGINE_HIVE_ENABLED}
+   * <li>If the table property is not set and hive metastore TABLE_PARAMS is not set
+   * then check the hive-site.xml property value{@link ConfigProperties#ENGINE_HIVE_ENABLED}
    * <li>If none of the above is enabled then use the default value {@link TableProperties#ENGINE_HIVE_ENABLED_DEFAULT}
    * </ol>
    * @param metadata Table metadata to use
+   * @param parameters Hive table parameters to use
    * @param conf The hive configuration to use
    * @return if the hive engine related values should be enabled or not
    */
-  private static boolean hiveEngineEnabled(TableMetadata metadata, Configuration conf) {
+  private static boolean hiveEngineEnabled(TableMetadata metadata, Map<String, String> parameters, Configuration conf) {

Review comment:
       @zhangdove: We have a related [discussion](https://lists.apache.org/thread.html/rfc9d82fd5f76cad4b8b7baea1bf00c0f4351feed4692c1a2ffa30788%40%3Cdev.iceberg.apache.org%3E) on the iceberg dev list which I think is not closed yet.
   
   We are trying to find a place for the different properties, and the end result should define also how the ENGINE_HIVE_ENABLED property should be handled. Maybe this should be an "Iceberg table property" which should be stored on the Iceberg table itself.
   
   Feel free to add your voice to the discussion!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org