[GitHub] [thrift] Jimexist commented on a diff in pull request #2635: python tests: support setuptools >=62.1 libpaths

[GitBox <gi...@apache.org>]

Jimexist commented on code in PR #2635:
URL: https://github.com/apache/thrift/pull/2635#discussion_r969052937


##########
lib/py/test/_import_local_thrift.py:
##########
@@ -25,6 +25,7 @@
 ROOT_DIR = os.path.dirname(os.path.dirname(os.path.dirname(SCRIPT_DIR)))
 
 for libpath in glob.glob(os.path.join(ROOT_DIR, 'lib', 'py', 'build', 'lib.*')):
-    if libpath.endswith('-%d.%d' % (sys.version_info[0], sys.version_info[1])):
+    if libpath.endswith('-%d.%d' % (sys.version_info[0], sys.version_info[1])) \
+        or libpath.endswith('-%s' % sys.implementation.cache_tag):

Review Comment:
   can you add inline code comment explaining this?



##########
test/py/util.py:
##########
@@ -28,5 +28,6 @@
 def local_libpath():
     globdir = os.path.join(_ROOT_DIR, 'lib', 'py', 'build', 'lib.*')
     for libpath in glob.glob(globdir):
-        if libpath.endswith('-%d.%d' % (sys.version_info[0], sys.version_info[1])):
+        if libpath.endswith('-%d.%d' % (sys.version_info[0], sys.version_info[1])) \
+            or libpath.endswith('-%s' % sys.implementation.cache_tag):

Review Comment:
   can you add inline code comment explaining this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org