[GitHub] [commons-collections] aherbert commented on a diff in pull request #330: Implemented clear() for COLLECTIONS-831

[GitBox <gi...@apache.org>]

aherbert commented on code in PR #330:
URL: https://github.com/apache/commons-collections/pull/330#discussion_r951276954


##########
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java:
##########
@@ -177,6 +177,14 @@ public final void testContains() {
         assertFalse(bf1.contains(bf4));
         assertTrue(bf4.contains(bf1));
     }
+    
+    @Test
+    public void testClear() {
+        BloomFilter bf1 = createFilter(getTestShape(), from1);
+        assertTrue( bf1.cardinality()>0 );

Review Comment:
   This should use the opposite of assertEquals:
   ```Java
   assertNotEquals(0, bf1.cardinality())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org