You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/05/15 00:23:24 UTC
[kudu-CR] KUDU-2191:bump Hive version
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10403
Change subject: KUDU-2191:bump Hive version
......................................................................
KUDU-2191:bump Hive version
Bumps the Hive version to 2.3.3 to include the important fix for
NotificationListener deadlock (HIVE-18885).
Change-Id: I441147ad9af4244fc7ec7cee1513088e5bdbe7ee
---
M thirdparty/vars.sh
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/10403/1
--
To view, visit http://gerrit.cloudera.org:8080/10403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I441147ad9af4244fc7ec7cee1513088e5bdbe7ee
Gerrit-Change-Number: 10403
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-2191:bump Hive version
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/10403 )
Change subject: KUDU-2191:bump Hive version
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/10403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I441147ad9af4244fc7ec7cee1513088e5bdbe7ee
Gerrit-Change-Number: 10403
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2191:bump Hive version
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10403 )
Change subject: KUDU-2191:bump Hive version
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10403/1/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/10403/1/thirdparty/vars.sh@a211
PS1, Line 211:
> oops I forgot about this when we talked about bumping the version. The Hiv
Hmm, I see. Then maybe we should do a custom build based on the current branch-2?
--
To view, visit http://gerrit.cloudera.org:8080/10403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I441147ad9af4244fc7ec7cee1513088e5bdbe7ee
Gerrit-Change-Number: 10403
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 15 May 2018 18:34:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2191:bump Hive version
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10403 )
Change subject: KUDU-2191:bump Hive version
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10403/1/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/10403/1/thirdparty/vars.sh@a211
PS1, Line 211:
oops I forgot about this when we talked about bumping the version. The Hive package we have now does include HIVE-17747, and it's critical to the functionality of the notification log listener. It looks like it was only backported to branch-2 and not the 2.3.x line, so we can't update to 2.3.3. I could do another custom build based off the current branch-2 if we want, though.
To double check this I cherry-picked this change on top of my notification log listener patch, and got failed tests and log messages like:
W0515 09:19:40.591070 215031808 hms_notification_log_listener.cc:116] Hive Metastore notification log listener poll failed: Corruption: invalid Hive Metastore event: 3 DROP_TABLE default.b: 'tableObjJson' field is not present
Which is what I'd expect if KUDU-17747 was missing from the HMS.
--
To view, visit http://gerrit.cloudera.org:8080/10403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I441147ad9af4244fc7ec7cee1513088e5bdbe7ee
Gerrit-Change-Number: 10403
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 15 May 2018 16:22:45 +0000
Gerrit-HasComments: Yes