You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by el...@apache.org on 2019/04/12 09:56:58 UTC
[hadoop] branch trunk updated: HDDS-1421. Avoid unnecessary object
allocations in TracingUtil
This is an automated email from the ASF dual-hosted git repository.
elek pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new a9b46c5 HDDS-1421. Avoid unnecessary object allocations in TracingUtil
a9b46c5 is described below
commit a9b46c58fe101ddad372f3651081dc38e5f06d37
Author: Arpit Agarwal <ar...@apache.org>
AuthorDate: Fri Apr 12 11:51:58 2019 +0200
HDDS-1421. Avoid unnecessary object allocations in TracingUtil
Closes #722
---
.../java/org/apache/hadoop/hdds/tracing/TracingUtil.java | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
index c274625..8e82a37 100644
--- a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
+++ b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
@@ -34,6 +34,8 @@ import org.apache.hadoop.hdds.scm.ScmConfigKeys;
*/
public final class TracingUtil {
+ private static final String NULL_SPAN_AS_STRING = "";
+
private TracingUtil() {
}
@@ -59,12 +61,13 @@ public final class TracingUtil {
* @return encoded tracing context.
*/
public static String exportCurrentSpan() {
- StringBuilder builder = new StringBuilder();
if (GlobalTracer.get().activeSpan() != null) {
+ StringBuilder builder = new StringBuilder();
GlobalTracer.get().inject(GlobalTracer.get().activeSpan().context(),
StringCodec.FORMAT, builder);
+ return builder.toString();
}
- return builder.toString();
+ return NULL_SPAN_AS_STRING;
}
/**
@@ -73,11 +76,12 @@ public final class TracingUtil {
* @return encoded tracing context.
*/
public static String exportSpan(Span span) {
- StringBuilder builder = new StringBuilder();
if (span != null) {
+ StringBuilder builder = new StringBuilder();
GlobalTracer.get().inject(span.context(), StringCodec.FORMAT, builder);
+ return builder.toString();
}
- return builder.toString();
+ return NULL_SPAN_AS_STRING;
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org