You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/05 08:17:46 UTC
[GitHub] [pulsar] yjshen opened a new pull request #6227: [REST API]Annotate
the APIs that may throw 307 temporary redirect exception
yjshen opened a new pull request #6227: [REST API]Annotate the APIs that may throw 307 temporary redirect exception
URL: https://github.com/apache/pulsar/pull/6227
Many of the existing REST API returns 307 temporary redirects without annotating them explicitly. This PR checks all occurrences of redirect exception and annotates them out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6227: [REST API]Annotate the
APIs that may throw 307 temporary redirect exception
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6227: [REST API]Annotate the APIs that may throw 307 temporary redirect exception
URL: https://github.com/apache/pulsar/pull/6227#issuecomment-582504876
Good job @yjshen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng commented on a change in pull request #6227: [REST
API]Annotate the APIs that may throw 307 temporary redirect exception
Posted by GitBox <gi...@apache.org>.
tuteng commented on a change in pull request #6227: [REST API]Annotate the APIs that may throw 307 temporary redirect exception
URL: https://github.com/apache/pulsar/pull/6227#discussion_r375129651
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v3/SourcesApiV3Resource.java
##########
@@ -138,8 +139,9 @@ public SourceConfig getSourceInfo(final @PathParam("tenant") String tenant,
response = SourceStatus.class
)
@ApiResponses(value = {
+ @ApiResponse(code = 307, message = "Current broker doesn't serve the namespace of this source"),
@ApiResponse(code = 400, message = "Invalid request"),
- @ApiResponse(code = 403, message = "The requester doesn't have admin permissions"),
+ @ApiResponse(code = 403, message = "The requester doesn't have admin permissions"),
@ApiResponse(code = 404, message = "The source doesn't exist")
Review comment:
Need format style?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] tuteng merged pull request #6227: [REST API]Annotate the
APIs that may throw 307 temporary redirect exception
Posted by GitBox <gi...@apache.org>.
tuteng merged pull request #6227: [REST API]Annotate the APIs that may throw 307 temporary redirect exception
URL: https://github.com/apache/pulsar/pull/6227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services