You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/10/24 18:49:41 UTC

[Impala-ASF-CR] IMPALA-13145: Set mold as the default linker

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23594


Change subject: IMPALA-13145: Set mold as the default linker
......................................................................

IMPALA-13145: Set mold as the default linker

Sets mold as the default linker to improve build performance.

Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
---
M README-build.md
M bin/impala-config.sh
2 files changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/23594/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13145: Set mold as the default linker

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-13145: Set mold as the default linker
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20773/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 19:11:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23594/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23594/10//COMMIT_MSG@19
PS10, Line 19: Removes undef.cpp after IMPALA-2765, which mold handled differently in a
             : way that broke sasl in thrift-server-test.
After removal of under.ccp, does everything work as expected when using gold or default GNU ld linker instead of the mold linker?



-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 17:41:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................

IMPALA-14527: Set mold as the default linker

Sets mold as the default linker to improve build performance.

Speeds rebuilds of './buildall.sh -skiptests' by ~40s while using only
10GiB of memory instead of 70+GiB with IMPALA_BUILD_THREADS=24.

Removes the guard in bootstrap_development.sh limiting
IMPALA_BUILD_THREADS for linking as it's no longer needed.

Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Reviewed-on: http://gerrit.cloudera.org:8080/23594
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M README-build.md
M bin/impala-config.sh
2 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.

Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23594/6/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23594/6/buildall.sh@84
PS6, Line 84: # Limit mold to a single job to avoid excessive memory consumption while fully utilizing
            : # available CPUs.
            : export MOLD_JOBS=1
> I think buildall.sh is not quite the right place for this. If we want it to
I figured it was primarily useful when doing a full build, with multiple link operations. But moving it to impala-config.sh isn't a big deal, most dev workflows are going to do 1 or 2 links, and they shouldn't be any slower with this option.



-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Nov 2025 21:19:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.

Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................


Abandoned

Fails testing with this version of mold.
-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.

Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23594/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23594/10//COMMIT_MSG@19
PS10, Line 19: Removes undef.cpp after IMPALA-2765, which mold handled differently in a
             : way that broke sasl in thrift-server-test.
> After removal of under.ccp, does everything work as expected when using gol
It should, I believe it was essentially dead code. I can separate that out and test it.



-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 17:58:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................


Patch Set 15: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14081/


-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 15
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Sep 2026 19:53:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14527: Set mold as the default linker

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.

Hello Riza Suminto, Pranav Lodha, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23594

to look at the new patch set (#7).

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................

IMPALA-14527: Set mold as the default linker

Sets mold as the default linker to improve build performance. Sets
MOLD_JOBS=1 to limit memory use; mold still fully utilizes CPUs in each
link. MOLD_JOBS can be overridden with IMPALA_MOLD_JOBS.

Speeds rebuilds of './buildall.sh -skiptests' by ~40s while using only
10GiB of memory instead of 70+GiB with IMPALA_BUILD_THREADS=24.

Removes the guard in bootstrap_development.sh limiting
IMPALA_BUILD_THREADS for linking as it's no longer needed.

Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
---
M README-build.md
M bin/bootstrap_development.sh
M bin/impala-config.sh
3 files changed, 8 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/23594/7
-- 
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Pranav Lodha <pr...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>