[GitHub] [arrow] felipecrv commented on a diff in pull request #34691: GH-34639: [C++] Support RecordBatch::FromStructArray even if struct array has nulls/offsets

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #34691:
URL: https://github.com/apache/arrow/pull/34691#discussion_r1147797323


##########
cpp/src/arrow/record_batch.cc:
##########
@@ -198,14 +198,20 @@ Result<std::shared_ptr<RecordBatch>> RecordBatch::MakeEmpty(
 }
 
 Result<std::shared_ptr<RecordBatch>> RecordBatch::FromStructArray(
-    const std::shared_ptr<Array>& array) {
+    const std::shared_ptr<Array>& array, MemoryPool* memory_pool) {

Review Comment:
   It  might be a good idea to review the callsites to this function and ensure they pass the context's memory pool instead of just passing the default one automatically.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org