You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tez.apache.org by GitBox <gi...@apache.org> on 2020/08/02 04:37:53 UTC
[GitHub] [tez] medb opened a new pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
medb opened a new pull request #74:
URL: https://github.com/apache/tez/pull/74
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] medb commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
medb commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876912020
@abstractdog this was a merge commit created by GitHub. I have squashed all changes into the single commit now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876905948
@medb : I can see the shade plugin bump solved the shading problem
however there are 3 commits, from which I don't get this one: https://github.com/apache/tez/pull/74/commits/00134f885047a9a9797e877699a617f29d3a60a9
could you please squash your commits to have the final one that we can merge into master from this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles edited a comment on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
jteagles edited a comment on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876574939
@abstractdog, do you see any issue with this version change. The last time version was upgraded was in https://issues.apache.org/jira/browse/TEZ-4040. Pig shades their version of roaringbitmap and hive doesn't use it as far as i can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
jteagles commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876574939
@abstractdog, do you see any issue with this version change. I saw you were the last to upgrade the version in https://issues.apache.org/jira/browse/TEZ-4040. Pig shades their version of roaringbitmap and hive doesn't use it as far as i can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] hadoop-yetus commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876929043
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 0s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 39s | master passed |
| +1 :green_heart: | compile | 2m 41s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 2m 26s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javadoc | 2m 32s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 55s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -0 :warning: | patch | 23m 46s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 38s | the patch passed |
| +1 :green_heart: | compile | 2m 38s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 2m 38s | the patch passed |
| +1 :green_heart: | compile | 2m 27s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 2m 27s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 17s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 56s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 47s | tez-aux-services in the patch passed. |
| +1 :green_heart: | unit | 73m 28s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 116m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/74 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 12ae5847bef9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / b31501d9b |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/2/testReport/ |
| Max. process+thread count | 1370 (vs. ulimit of 5500) |
| modules | C: tez-plugins/tez-aux-services . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/2/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] hadoop-yetus commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876964164
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 17m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 57s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 37s | master passed |
| +1 :green_heart: | compile | 2m 39s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 2m 25s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javadoc | 2m 30s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 56s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 37s | the patch passed |
| +1 :green_heart: | compile | 2m 42s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 2m 42s | the patch passed |
| +1 :green_heart: | compile | 2m 26s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 2m 26s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 18s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 57s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 48s | tez-aux-services in the patch passed. |
| +1 :green_heart: | unit | 71m 7s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 130m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/74 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 4179bc58c129 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / b31501d9b |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/3/testReport/ |
| Max. process+thread count | 1396 (vs. ulimit of 5500) |
| modules | C: tez-plugins/tez-aux-services . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/3/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
jteagles commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-877291017
+1. Thanks for this change. Committing to master and branch-0.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876757909
hive has only transitive dependencies on roaringbitmap, one from tez, other is from spark core, which is already 0.7.45, so it's unlikely that this change will bring confusion there from tez side
if the rebased version of this change will pass precommit tests, I would consider it safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] medb commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
medb commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876904757
@abstractdog precommit tests are passing after rebase - I needed to upgrade Maven Shade Plugin version to fix the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles merged pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
jteagles merged pull request #74:
URL: https://github.com/apache/tez/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] hadoop-yetus commented on pull request #74: TEZ-4214. Upgrade RoaringBitmap version to 0.7.45
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #74:
URL: https://github.com/apache/tez/pull/74#issuecomment-876868216
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 16m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 1s | master passed |
| +1 :green_heart: | compile | 2m 16s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 2m 2s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javadoc | 2m 22s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 35s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -0 :warning: | patch | 21m 43s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 4m 7s | root in the patch failed. |
| +1 :green_heart: | compile | 2m 17s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 2m 17s | the patch passed |
| +1 :green_heart: | compile | 2m 2s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 2m 2s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 57s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 36s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 71m 29s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 122m 47s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/74 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux b1eddf3f2c06 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / b31501d9b |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| mvninstall | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/artifact/out/patch-mvninstall-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/testReport/ |
| Max. process+thread count | 2089 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org