[GitHub] incubator-quickstep pull request #341: Used MergeFrom instead of CopyFrom.

[zuyu <gi...@git.apache.org>]

GitHub user zuyu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/341

    Used MergeFrom instead of CopyFrom.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuyu/incubator-quickstep use-merge-from

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #341
    
----
commit 612e103cb590a8f7735c5e7af7529c4c68956bbf
Author: Zuyu Zhang <zu...@...>
Date:   2018-04-20T20:46:50Z

    Used MergeFrom instead of CopyFrom.

----


---

[GitHub] incubator-quickstep pull request #341: Used MergeFrom instead of CopyFrom.

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/341


---

[GitHub] incubator-quickstep issue #341: Used MergeFrom instead of CopyFrom.

[zuyu <gi...@git.apache.org>]

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/341
  
    `CopyFrom` = `Clear` + `MergeFrom`.
    
    Since we set a value for each new `proto`, we do not need `Clear` to reset the memory.


---

[GitHub] incubator-quickstep issue #341: Used MergeFrom instead of CopyFrom.

[hbdeshmukh <gi...@git.apache.org>]

Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/341
  
    What's the difference between the two functions?


---

[GitHub] incubator-quickstep issue #341: Used MergeFrom instead of CopyFrom.

[hbdeshmukh <gi...@git.apache.org>]

Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/341
  
    Looks good to me. 


---