You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/02/19 01:48:19 UTC
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15208
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
IMPALA-8013: switch from boost to std locks
The locks are mostly drop-in replacements that wrap
the same pthread implementations.
I went through all of the boost mutex/lock/thread-related
includes and updated them so that the boost mutex headers
are not pulled in. E.g. <boost/thread.hpp> is an uber-header
that pulls in *all* of the boost mutex and thread headers.
std::shared_lock doesn't exist until c++17, so we don't
replace this.
Compile Time:
I confirmed that preprocessed files got slightly shorter,
which translated into a slight compile time improvement
for a full build.
Before:
real 9m27.502s
user 64m39.775s
sys 2m49.002s
After:
real 9m19.071s
user 63m13.950s
sys 2m45.066s
Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
---
M be/src/benchmarks/free-lists-benchmark.cc
M be/src/benchmarks/lock-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/codegen/codegen-symbol-emitter.cc
M be/src/codegen/codegen-symbol-emitter.h
M be/src/codegen/instruction-counter-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/atomic-test.cc
M be/src/common/logging.cc
M be/src/common/names.h
M be/src/common/object-pool.h
M be/src/exec/blocking-join-node.h
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/external-data-source-executor.cc
M be/src/exec/hbase-table-writer.h
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/exec/kudu-scan-node.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/plan-root-sink.cc
M be/src/rpc/auth-provider.h
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
M be/src/rpc/rpc-trace.h
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/runtime/bufferpool/free-list.h
M be/src/runtime/bufferpool/reservation-tracker.cc
M be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.h
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/dml-exec-state.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/hbase-table-factory.cc
M be/src/runtime/hbase-table-factory.h
M be/src/runtime/hbase-table.h
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
M be/src/runtime/initial-reservations.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/handle-cache.h
M be/src/runtime/io/handle-cache.inline.h
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/runtime/mem-tracker.h
M be/src/runtime/query-exec-mgr.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
M be/src/runtime/runtime-filter.h
M be/src/runtime/runtime-filter.inline.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/scanner-mem-limiter.cc
M be/src/runtime/sorted-run-merger.h
M be/src/runtime/sorter.cc
M be/src/runtime/thread-resource-mgr.cc
M be/src/runtime/thread-resource-mgr.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler.h
M be/src/service/child-query.h
M be/src/service/client-request-state.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.h
M be/src/statestore/failure-detector.cc
M be/src/statestore/failure-detector.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/testutil/impalad-query-executor.h
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/util/blocking-queue-test.cc
M be/src/util/blocking-queue.h
M be/src/util/collection-metrics.h
M be/src/util/condition-variable.h
M be/src/util/cyclic-barrier-test.cc
M be/src/util/cyclic-barrier.h
M be/src/util/hdfs-bulk-ops.h
M be/src/util/histogram-metric.h
M be/src/util/internal-queue-test.cc
M be/src/util/internal-queue.h
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M be/src/util/metrics.h
M be/src/util/periodic-counter-updater.h
M be/src/util/promise-test.cc
M be/src/util/promise.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M be/src/util/sharded-query-map-util.h
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
M be/src/util/stopwatch.h
M be/src/util/thread-pool-test.cc
M be/src/util/thread-pool.h
M be/src/util/thread.h
M be/src/util/webserver.cc
132 files changed, 328 insertions(+), 348 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/15208/6
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 10:
This hit the issue fixed by https://github.com/cloudera/impala-lzo/commit/7b6b80a2cfe4eec709600ebc61a69993d1149196
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 02:01:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has removed a vote on this change.
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5370/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 20:55:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 12:
The failure seems unrelated, restarting GVO again.
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/9396/testReport/junit/query_test.test_scanners/TestScannerReservation/test_scanners_protocol__beeswax___exec_option____batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__text_none_/
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 13:57:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15208/8/be/src/runtime/bufferpool/buffer-allocator.cc
File be/src/runtime/bufferpool/buffer-allocator.cc:
http://gerrit.cloudera.org:8080/#/c/15208/8/be/src/runtime/bufferpool/buffer-allocator.cc@82
PS8, Line 82: Uses std::unique_lock instead of
: /// std::unique_lock because it is movable.
> This comment stops making sense.
oops, yeah bad search/replace.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 20:07:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 10: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5370/
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 01:17:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5373/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 02:02:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 10: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 06:24:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15208
to look at the new patch set (#8).
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
IMPALA-8013: switch from boost to std locks
The locks are mostly drop-in replacements that wrap
the same pthread implementations.
I went through all of the boost mutex/lock/thread-related
includes and updated them so that the boost mutex headers
are not pulled in. E.g. <boost/thread.hpp> is an uber-header
that pulls in *all* of the boost mutex and thread headers.
std::shared_lock doesn't exist until c++17, so we don't
replace this.
Compile Time:
I confirmed that preprocessed files got slightly shorter,
which translated into a slight compile time improvement
for a full build.
Before:
real 9m27.502s
user 64m39.775s
sys 2m49.002s
After:
real 9m19.071s
user 63m13.950s
sys 2m45.066s
Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
---
M be/src/benchmarks/free-lists-benchmark.cc
M be/src/benchmarks/lock-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/codegen/codegen-symbol-emitter.cc
M be/src/codegen/codegen-symbol-emitter.h
M be/src/codegen/instruction-counter-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/atomic-test.cc
M be/src/common/logging.cc
M be/src/common/names.h
M be/src/common/object-pool.h
M be/src/exec/blocking-join-node.h
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/external-data-source-executor.cc
M be/src/exec/hbase-table-writer.h
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/exec/kudu-scan-node.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/plan-root-sink.cc
M be/src/rpc/auth-provider.h
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
M be/src/rpc/rpc-trace.h
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/runtime/bufferpool/free-list.h
M be/src/runtime/bufferpool/reservation-tracker.cc
M be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.h
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/dml-exec-state.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/hbase-table-factory.cc
M be/src/runtime/hbase-table-factory.h
M be/src/runtime/hbase-table.h
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
M be/src/runtime/initial-reservations.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/handle-cache.h
M be/src/runtime/io/handle-cache.inline.h
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/runtime/mem-tracker.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
M be/src/runtime/runtime-filter.h
M be/src/runtime/runtime-filter.inline.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/scanner-mem-limiter.cc
M be/src/runtime/sorted-run-merger.h
M be/src/runtime/sorter.cc
M be/src/runtime/thread-resource-mgr.cc
M be/src/runtime/thread-resource-mgr.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler.h
M be/src/service/child-query.h
M be/src/service/client-request-state.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.h
M be/src/statestore/failure-detector.cc
M be/src/statestore/failure-detector.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/testutil/impalad-query-executor.h
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/util/blocking-queue-test.cc
M be/src/util/blocking-queue.h
M be/src/util/collection-metrics.h
M be/src/util/condition-variable.h
M be/src/util/cyclic-barrier-test.cc
M be/src/util/cyclic-barrier.h
M be/src/util/hdfs-bulk-ops.h
M be/src/util/histogram-metric.h
M be/src/util/internal-queue-test.cc
M be/src/util/internal-queue.h
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M be/src/util/metrics.h
M be/src/util/periodic-counter-updater.h
M be/src/util/promise-test.cc
M be/src/util/promise.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M be/src/util/sharded-query-map-util.h
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
M be/src/util/stopwatch.h
M be/src/util/thread-pool-test.cc
M be/src/util/thread-pool.h
M be/src/util/thread.h
M be/src/util/webserver.cc
131 files changed, 327 insertions(+), 352 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/15208/8
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5271/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 18:14:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5275/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 20:50:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 7:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/exec/hdfs-scan-node-base.h
File be/src/exec/hdfs-scan-node-base.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/exec/hdfs-scan-node-base.h@27
PS7, Line 27: #include <boost/thread/shared_mutex.hpp>
> nit: should this be on line 28, and line 27 should be a newline?
Done
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/bufferpool/buffer-pool-internal.h
File be/src/runtime/bufferpool/buffer-pool-internal.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/bufferpool/buffer-pool-internal.h@79
PS7, Line 79:
> nit: delete new line?
Done
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/coordinator-backend-state.h
File be/src/runtime/coordinator-backend-state.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/coordinator-backend-state.h@23
PS7, Line 23: #include <mutex>
> nit: same as before, group this with the other std library includes?
Done
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/io/scan-range.cc
File be/src/runtime/io/scan-range.cc:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/io/scan-range.cc@306
PS7, Line 306: std
> nit: remote std here and in 'std::mutex'
Done
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/query-exec-mgr.h
File be/src/runtime/query-exec-mgr.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/query-exec-mgr.h@20
PS7, Line 20: #include <mutex>
: #include <unordered_map>
> i think this was removed in https://github.com/apache/impala/commit/04fd9ae
oh nice catch, thanks
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/runtime-filter-bank.h
File be/src/runtime/runtime-filter-bank.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/runtime-filter-bank.h@31
PS7, Line 31: #include "util/condition-variable.h"
> is this used?
Oops, I tried to replace condition_variable and didn't remove this change when I abandoned it.
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/service/impala-hs2-server.cc@1071
PS7, Line 1071: std
> nit: can remove the std
Done
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 17:30:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
IMPALA-8013: switch from boost to std locks
The locks are mostly drop-in replacements that wrap
the same pthread implementations.
I went through all of the boost mutex/lock/thread-related
includes and updated them so that the boost mutex headers
are not pulled in. E.g. <boost/thread.hpp> is an uber-header
that pulls in *all* of the boost mutex and thread headers.
std::shared_lock doesn't exist until c++17, so we don't
replace this.
Compile Time:
I confirmed that preprocessed files got slightly shorter,
which translated into a slight compile time improvement
for a full build.
Before:
real 9m27.502s
user 64m39.775s
sys 2m49.002s
After:
real 9m19.071s
user 63m13.950s
sys 2m45.066s
Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Reviewed-on: http://gerrit.cloudera.org:8080/15208
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/benchmarks/free-lists-benchmark.cc
M be/src/benchmarks/lock-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/codegen/codegen-symbol-emitter.cc
M be/src/codegen/codegen-symbol-emitter.h
M be/src/codegen/instruction-counter-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/atomic-test.cc
M be/src/common/logging.cc
M be/src/common/names.h
M be/src/common/object-pool.h
M be/src/exec/blocking-join-node.h
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/external-data-source-executor.cc
M be/src/exec/hbase-table-writer.h
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/exec/join-builder.h
M be/src/exec/kudu-scan-node.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/plan-root-sink.cc
M be/src/rpc/auth-provider.h
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
M be/src/rpc/rpc-trace.h
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/runtime/bufferpool/free-list.h
M be/src/runtime/bufferpool/reservation-tracker.cc
M be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.h
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/dml-exec-state.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/hbase-table-factory.cc
M be/src/runtime/hbase-table-factory.h
M be/src/runtime/hbase-table.h
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
M be/src/runtime/initial-reservations.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/handle-cache.h
M be/src/runtime/io/handle-cache.inline.h
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/runtime/mem-tracker.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
M be/src/runtime/runtime-filter.h
M be/src/runtime/runtime-filter.inline.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/scanner-mem-limiter.cc
M be/src/runtime/sorted-run-merger.h
M be/src/runtime/sorter.cc
M be/src/runtime/thread-resource-mgr.cc
M be/src/runtime/thread-resource-mgr.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler.h
M be/src/service/child-query.h
M be/src/service/client-request-state.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.h
M be/src/statestore/failure-detector.cc
M be/src/statestore/failure-detector.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/testutil/impalad-query-executor.h
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/util/blocking-queue-test.cc
M be/src/util/blocking-queue.h
M be/src/util/collection-metrics.h
M be/src/util/condition-variable.h
M be/src/util/cyclic-barrier-test.cc
M be/src/util/cyclic-barrier.cc
M be/src/util/cyclic-barrier.h
M be/src/util/hdfs-bulk-ops.h
M be/src/util/histogram-metric.h
M be/src/util/internal-queue-test.cc
M be/src/util/internal-queue.h
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M be/src/util/metrics.h
M be/src/util/periodic-counter-updater.h
M be/src/util/promise-test.cc
M be/src/util/promise.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M be/src/util/sharded-query-map-util.h
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
M be/src/util/stopwatch.h
M be/src/util/thread-pool-test.cc
M be/src/util/thread-pool.h
M be/src/util/thread.h
M be/src/util/webserver.cc
133 files changed, 330 insertions(+), 367 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 20:55:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 6:
This was a follow-on to the original IWYU patch that I did earlier, it's pretty mechanical too.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 01:49:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5383/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 06:22:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5263/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 02:37:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5283/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 07:28:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 18:30:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 06:22:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 17:42:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 11:
fyi the build failed because of IMPALA-9390
The patch that will hopefully fix this is on its way to be merged: https://gerrit.cloudera.org/#/c/15229/
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 15:22:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 13:
thanks for restarting it
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 13
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 18:37:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15208
to look at the new patch set (#11).
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
IMPALA-8013: switch from boost to std locks
The locks are mostly drop-in replacements that wrap
the same pthread implementations.
I went through all of the boost mutex/lock/thread-related
includes and updated them so that the boost mutex headers
are not pulled in. E.g. <boost/thread.hpp> is an uber-header
that pulls in *all* of the boost mutex and thread headers.
std::shared_lock doesn't exist until c++17, so we don't
replace this.
Compile Time:
I confirmed that preprocessed files got slightly shorter,
which translated into a slight compile time improvement
for a full build.
Before:
real 9m27.502s
user 64m39.775s
sys 2m49.002s
After:
real 9m19.071s
user 63m13.950s
sys 2m45.066s
Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
---
M be/src/benchmarks/free-lists-benchmark.cc
M be/src/benchmarks/lock-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/codegen/codegen-symbol-emitter.cc
M be/src/codegen/codegen-symbol-emitter.h
M be/src/codegen/instruction-counter-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/atomic-test.cc
M be/src/common/logging.cc
M be/src/common/names.h
M be/src/common/object-pool.h
M be/src/exec/blocking-join-node.h
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/external-data-source-executor.cc
M be/src/exec/hbase-table-writer.h
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/exec/join-builder.h
M be/src/exec/kudu-scan-node.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/plan-root-sink.cc
M be/src/rpc/auth-provider.h
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
M be/src/rpc/rpc-trace.h
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/runtime/bufferpool/free-list.h
M be/src/runtime/bufferpool/reservation-tracker.cc
M be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.h
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/dml-exec-state.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/hbase-table-factory.cc
M be/src/runtime/hbase-table-factory.h
M be/src/runtime/hbase-table.h
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
M be/src/runtime/initial-reservations.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/handle-cache.h
M be/src/runtime/io/handle-cache.inline.h
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/runtime/mem-tracker.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
M be/src/runtime/runtime-filter.h
M be/src/runtime/runtime-filter.inline.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/scanner-mem-limiter.cc
M be/src/runtime/sorted-run-merger.h
M be/src/runtime/sorter.cc
M be/src/runtime/thread-resource-mgr.cc
M be/src/runtime/thread-resource-mgr.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler.h
M be/src/service/child-query.h
M be/src/service/client-request-state.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.h
M be/src/statestore/failure-detector.cc
M be/src/statestore/failure-detector.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/testutil/impalad-query-executor.h
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/util/blocking-queue-test.cc
M be/src/util/blocking-queue.h
M be/src/util/collection-metrics.h
M be/src/util/condition-variable.h
M be/src/util/cyclic-barrier-test.cc
M be/src/util/cyclic-barrier.cc
M be/src/util/cyclic-barrier.h
M be/src/util/hdfs-bulk-ops.h
M be/src/util/histogram-metric.h
M be/src/util/internal-queue-test.cc
M be/src/util/internal-queue.h
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M be/src/util/metrics.h
M be/src/util/periodic-counter-updater.h
M be/src/util/promise-test.cc
M be/src/util/promise.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M be/src/util/sharded-query-map-util.h
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
M be/src/util/stopwatch.h
M be/src/util/thread-pool-test.cc
M be/src/util/thread-pool.h
M be/src/util/thread.h
M be/src/util/webserver.cc
133 files changed, 330 insertions(+), 367 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/15208/11
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 9: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 20:07:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5384/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 13:57:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 11: Code-Review+2
I'm going to wait a bit to try merging this - there are a lot of merges in flight so I think there's too much risk of a collision right now.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 00:00:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 9: Code-Review+2
I don't see anything else, so bumping to +2
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 20:12:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 12: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5383/
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Feb 2020 10:55:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 11: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5374/
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 11:15:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15208
to look at the new patch set (#9).
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
IMPALA-8013: switch from boost to std locks
The locks are mostly drop-in replacements that wrap
the same pthread implementations.
I went through all of the boost mutex/lock/thread-related
includes and updated them so that the boost mutex headers
are not pulled in. E.g. <boost/thread.hpp> is an uber-header
that pulls in *all* of the boost mutex and thread headers.
std::shared_lock doesn't exist until c++17, so we don't
replace this.
Compile Time:
I confirmed that preprocessed files got slightly shorter,
which translated into a slight compile time improvement
for a full build.
Before:
real 9m27.502s
user 64m39.775s
sys 2m49.002s
After:
real 9m19.071s
user 63m13.950s
sys 2m45.066s
Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
---
M be/src/benchmarks/free-lists-benchmark.cc
M be/src/benchmarks/lock-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/codegen/codegen-symbol-emitter.cc
M be/src/codegen/codegen-symbol-emitter.h
M be/src/codegen/instruction-counter-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/atomic-test.cc
M be/src/common/logging.cc
M be/src/common/names.h
M be/src/common/object-pool.h
M be/src/exec/blocking-join-node.h
M be/src/exec/blocking-plan-root-sink.cc
M be/src/exec/blocking-plan-root-sink.h
M be/src/exec/buffered-plan-root-sink.h
M be/src/exec/external-data-source-executor.cc
M be/src/exec/hbase-table-writer.h
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-scan-node.h
M be/src/exec/kudu-scan-node.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/exec/plan-root-sink.cc
M be/src/rpc/auth-provider.h
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
M be/src/rpc/rpc-trace.h
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-allocator.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/runtime/bufferpool/free-list.h
M be/src/runtime/bufferpool/reservation-tracker.cc
M be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.h
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/dml-exec-state.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/hbase-table-factory.cc
M be/src/runtime/hbase-table-factory.h
M be/src/runtime/hbase-table.h
M be/src/runtime/hdfs-fs-cache.cc
M be/src/runtime/hdfs-fs-cache.h
M be/src/runtime/initial-reservations.cc
M be/src/runtime/io/disk-io-mgr-internal.h
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/handle-cache.h
M be/src/runtime/io/handle-cache.inline.h
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/lib-cache.cc
M be/src/runtime/lib-cache.h
M be/src/runtime/mem-tracker.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-filter-bank.h
M be/src/runtime/runtime-filter.h
M be/src/runtime/runtime-filter.inline.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/scanner-mem-limiter.cc
M be/src/runtime/sorted-run-merger.h
M be/src/runtime/sorter.cc
M be/src/runtime/thread-resource-mgr.cc
M be/src/runtime/thread-resource-mgr.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler.h
M be/src/service/child-query.h
M be/src/service/client-request-state.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.h
M be/src/statestore/failure-detector.cc
M be/src/statestore/failure-detector.h
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/testutil/impalad-query-executor.h
M be/src/transport/TSaslServerTransport.cpp
M be/src/transport/TSaslServerTransport.h
M be/src/util/blocking-queue-test.cc
M be/src/util/blocking-queue.h
M be/src/util/collection-metrics.h
M be/src/util/condition-variable.h
M be/src/util/cyclic-barrier-test.cc
M be/src/util/cyclic-barrier.h
M be/src/util/hdfs-bulk-ops.h
M be/src/util/histogram-metric.h
M be/src/util/internal-queue-test.cc
M be/src/util/internal-queue.h
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M be/src/util/metrics.h
M be/src/util/periodic-counter-updater.h
M be/src/util/promise-test.cc
M be/src/util/promise.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M be/src/util/sharded-query-map-util.h
M be/src/util/simple-logger.cc
M be/src/util/simple-logger.h
M be/src/util/stopwatch.h
M be/src/util/thread-pool-test.cc
M be/src/util/thread-pool.h
M be/src/util/thread.h
M be/src/util/webserver.cc
131 files changed, 327 insertions(+), 353 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/15208/9
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5374/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 06:41:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 7: Code-Review+1
(7 comments)
mostly nits
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/exec/hdfs-scan-node-base.h
File be/src/exec/hdfs-scan-node-base.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/exec/hdfs-scan-node-base.h@27
PS7, Line 27: #include <boost/thread/shared_mutex.hpp>
nit: should this be on line 28, and line 27 should be a newline?
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/bufferpool/buffer-pool-internal.h
File be/src/runtime/bufferpool/buffer-pool-internal.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/bufferpool/buffer-pool-internal.h@79
PS7, Line 79:
nit: delete new line?
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/coordinator-backend-state.h
File be/src/runtime/coordinator-backend-state.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/coordinator-backend-state.h@23
PS7, Line 23: #include <mutex>
nit: same as before, group this with the other std library includes?
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/io/scan-range.cc
File be/src/runtime/io/scan-range.cc:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/io/scan-range.cc@306
PS7, Line 306: std
nit: remote std here and in 'std::mutex'
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/query-exec-mgr.h
File be/src/runtime/query-exec-mgr.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/query-exec-mgr.h@20
PS7, Line 20: #include <mutex>
: #include <unordered_map>
i think this was removed in https://github.com/apache/impala/commit/04fd9ae268d89b07e2a692a916bf2ddcfb2e351b - don't think are needed, right?
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/runtime-filter-bank.h
File be/src/runtime/runtime-filter-bank.h:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/runtime/runtime-filter-bank.h@31
PS7, Line 31: #include "util/condition-variable.h"
is this used?
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:
http://gerrit.cloudera.org:8080/#/c/15208/7/be/src/service/impala-hs2-server.cc@1071
PS7, Line 1071: std
nit: can remove the std
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 17:00:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
This looks good to me. One small comment.
http://gerrit.cloudera.org:8080/#/c/15208/8/be/src/runtime/bufferpool/buffer-allocator.cc
File be/src/runtime/bufferpool/buffer-allocator.cc:
http://gerrit.cloudera.org:8080/#/c/15208/8/be/src/runtime/bufferpool/buffer-allocator.cc@82
PS8, Line 82: Uses std::unique_lock instead of
: /// std::unique_lock because it is movable.
This comment stops making sense.
--
To view, visit http://gerrit.cloudera.org:8080/15208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f
Gerrit-Change-Number: 15208
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 18:14:41 +0000
Gerrit-HasComments: Yes