You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/16 22:35:16 UTC
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2761: Towards building just on JDK11.
lkishalmi commented on a change in pull request #2761:
URL: https://github.com/apache/netbeans/pull/2761#discussion_r577187116
##########
File path: platform/o.n.bootstrap/src/org/netbeans/StandardModuleData.java
##########
@@ -78,7 +80,12 @@ public StandardModuleData(Manifest mf, StandardModule forModule) throws InvalidE
if (classPath != null) {
StringTokenizer tok = new StringTokenizer(classPath);
while (tok.hasMoreTokens()) {
- String ext = tok.nextToken().replace("%20", " "); // NOI18N
+ String ext;
+ try {
+ ext = URLDecoder.decode(tok.nextToken(), "UTF-8");
+ } catch (UnsupportedEncodingException ex) {
+ throw new IllegalStateException(ex);
+ }
File extfile;
if (ext.equals("${java.home}/lib/ext/jfxrt.jar")) { // NOI18N
Review comment:
It seems we do not really require that $ sign.
Also there are some JDK 1.7 checks which could be removed as well.
##########
File path: platform/libs.javafx/manifest.mf
##########
@@ -38,5 +38,4 @@ OpenIDE-Module-Provides: javafx.animation,
javafx.util,
javafx.util.converter,
netscape.javascript
-Class-Path: ${java.home}/lib/ext/jfxrt.jar
-
+Class-Path: %24%7Bjava.home%7D%2F/lib/ext/jfxrt.jar
Review comment:
Well, this is ugly. Cant we just have JAVA_HOME/lib/ext/jfxrt.jar ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists