You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/11 07:18:04 UTC
[GitHub] KarmaGYZ commented on a change in pull request #7466: [FLINK-11304]
Fix typo in time attributes doc
KarmaGYZ commented on a change in pull request #7466: [FLINK-11304] Fix typo in time attributes doc
URL: https://github.com/apache/flink/pull/7466#discussion_r247020179
##########
File path: docs/dev/table/streaming/time_attributes.md
##########
@@ -284,9 +284,9 @@ public class UserActionSource implements StreamTableSource<Row>, DefinedRowtimeA
}
@Override
- public String getRowtimeAttribute() {
- // Mark the "UserActionTime" attribute as event-time attribute.
- return "UserActionTime";
+ public List[RowtimeAttributeDescriptor] getRowtimeAttributeDescriptors() {
+ // Mark the "UserActionTime" attribute as event-time attribute.
+ // return List<RowtimeAttributeDescriptor>;
Review comment:
I think we should implement it in doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services