You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2015/09/23 08:29:04 UTC

[jira] [Moved] (YETUS-53) Wrong function names in test-patch bigtop personality

     [ https://issues.apache.org/jira/browse/YETUS-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey moved HADOOP-12401 to YETUS-53:
-------------------------------------------

    Affects Version/s:     (was: HADOOP-12111)
          Component/s:     (was: yetus)
                       Test Patch
                  Key: YETUS-53  (was: HADOOP-12401)
              Project: Yetus  (was: Hadoop Common)

> Wrong function names in test-patch bigtop personality
> -----------------------------------------------------
>
>                 Key: YETUS-53
>                 URL: https://issues.apache.org/jira/browse/YETUS-53
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Kengo Seki
>
> In dev-support/personality/bigtop.sh:
> {code}
>  51 function bigtop_precheck_postinstall
>  52 {
>  53   if [[ ${BIGTOP_PUPPETSETUP} = "true" ]]; then
>  54     pushd "${BASEDIR}" >/dev/null
>  55     echo_and_redirect "${PATCH_DIR}/bigtop-branch-toolchain.txt" "${GRADLEW}" toolchain
>  56     popd >/dev/null
>  57   fi
>  58 }
>  59 
>  60 function bigtop_postapply_postinstall
>  61 {
>  62   if [[ ${BIGTOP_PUPPETSETUP} = "true" ]]; then
>  63     pushd "${BASEDIR}" >/dev/null
>  64     echo_and_redirect "${PATCH_DIR}/bigtop-patch-toolchain.txt" "${GRADLEW}" toolchain
>  65     popd >/dev/null
>  66   fi
>  67 }
> {code}
> Their names are not proper for test-patch plugin callback functions. Maybe it should be like:
> {code}
> function bigtop_precompile
> {
>   declare codebase=$1
>   if [[ ${BIGTOP_PUPPETSETUP} = "true" && ( ${codebase} = "branch" || ${codebase} = "patch" ) ]]; then
>     pushd "${BASEDIR}" >/dev/null
>     echo_and_redirect "${PATCH_DIR}/bigtop-${codebase}-toolchain.txt" "${GRADLEW}" toolchain
>     popd >/dev/null
>   fi  
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)