You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/01 02:29:24 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5214: Fix typo

wu-sheng commented on a change in pull request #5214:
URL: https://github.com/apache/skywalking/pull/5214#discussion_r463909299



##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -135,7 +135,12 @@ property key | Description | Default |
 `correlation.element_max_number`|Max element count of the correlation context.|`3`|
 `correlation.value_max_length`|Max value length of correlation context element.|`128`|
 `plugin.kafka.bootstrap_servers`| A list of host/port pairs to use for establishing the initial connection to the Kafka cluster. | `localhost:9092`
-`plugin.kafka.consumer_config`| Kafka producer configuration. |
+`plugin.kafka.producer_config`| Kafka producer configuration. Read [producer configure](http://kafka.apache.org/24/documentation.html#producerconfigs) to get more details. | |

Review comment:
       ```suggestion
   `plugin.kafka.producer_config`| Kafka producer configuration. Read [producer configure](http://kafka.apache.org/24/documentation.html#producerconfigs) to get more details. Check [Kafka report doc](How-to-enable-kafka-reporter.md) for more details and examples. | |
   ```

##########
File path: docs/en/setup/service-agent/java-agent/How-to-enable-kafka-reporter.md
##########
@@ -15,4 +15,4 @@ plugin.kafka.producer_config[delivery.timeout.ms]=12000
 
 Kafka reporter plugin support to customize all configurations of listed in [here](http://kafka.apache.org/24/documentation.html#producerconfigs).
 
-After you activated the Kafka reporter, you need to open [Kafka fetcher](../../backend/backend-fetcher.md#kafka-fetcher) at the OAP side.
\ No newline at end of file
+Before you activated the Kafka reporter, you have to make sure that [Kafka fetcher](../../backend/backend-fetcher.md#kafka-fetcher) has been in service.

Review comment:
       ```suggestion
   Before you activated the Kafka reporter, you have to make sure that [Kafka fetcher](../../backend/backend-fetcher.md#kafka-fetcher) has been opened in service.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org