You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/09/21 10:22:48 UTC

[I] [Bug] Consumer page protocol tags lose their color: PROTOCOL_MAP keyed by values the API never sends [rocketmq-dashboard]

Frun1na opened a new issue, #4742:
URL: https://github.com/apache/rocketmq-dashboard/issues/4742

   ### Before Creating the Bug Report
   
   - [x] I have searched the [open issues](https://github.com/apache/rocketmq-dashboard/issues) and found no similar issue.
   
   ### What Happened
   
   On the Consumer Group page, the protocol tags in a group's client list (实例 / clients column) render
   with the default gray color instead of the intended green (gRPC) / geekblue (Remoting).
   
   `PROTOCOL_MAP` in `web/src/constants/theme.ts` is keyed by `REMOTING` / `GRPC`, but the server
   serializes the `Protocol` enum by its enum name — `gRPC` / `Remoting`
   (`org.apache.rocketmq.studio.common.domain.enums.Protocol`). The lookup therefore never matches, and
   the render falls back to `{ labelKey: protocol, color: 'default' }`: the text is still correct
   (because `t(protocol)` echoes the raw value), but the color is lost.
   
   The map only ever matched the stale mock data in `web/src/mock/consumers.ts`, which used the same
   uppercase shells; `mock/clients.ts` already uses the real values, which is why the clients page
   renders its protocol tags correctly.
   
   ### Expected Behavior
   
   Protocol tags on the consumer page carry the same colors as on the clients page: green for `gRPC`,
   geekblue for `Remoting`.
   
   ### Steps to Reproduce
   
   1. Open an instance's Consumer Group page and expand a group's client instances (or open the group
      detail modal).
   2. Look at the 协议 column: the tag text is correct (`gRPC` / `Remoting`) but the color is the
      default gray, unlike the clients page.
   
   ### Environment
   
   - RocketMQ Studio `rocketmq-studio` @ `7ce9a682`
   - Frontend: `web/src/constants/theme.ts` (`PROTOCOL_MAP`), `web/src/pages/instance/consumer.tsx`
   
   ### Are You Willing to Submit a Pull Request?
   
   Yes — #4741 fixes this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Consumer page protocol tags lose their color: PROTOCOL_MAP keyed by values the API never sends [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #4742: [Bug] Consumer page protocol tags lose their color: PROTOCOL_MAP keyed by values the API never sends
URL: https://github.com/apache/rocketmq-dashboard/issues/4742


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Consumer page protocol tags lose their color: PROTOCOL_MAP keyed by values the API never sends [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4742:
URL: https://github.com/apache/rocketmq-dashboard/issues/4742#issuecomment-5760930062

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** `PROTOCOL_MAP` in `web/src/constants/theme.ts` is keyed by `REMOTING` / `GRPC` (uppercase), but the server serializes the `Protocol` enum by its Java enum name — `gRPC` / `Remoting` (mixed case). The lookup never matches, so the render falls back to `{ labelKey: protocol, color: 'default' }`. The text displays correctly (via `t(protocol)` echo), but the intended color coding (green for gRPC, geekblue for Remoting) is lost.
   
   **Impact:** Consumer Group page client list shows all protocol tags in default gray instead of their intended distinct colors, reducing visual clarity.
   
   **Severity:** Low — cosmetic issue, no data loss or functional breakage.
   
   **Note:** This is the same class of issue as #4733 (filter-mode codes) — mock data and frontend constants drifted from the actual API contract.
   
   PR #4741 from the author addresses this. Maintainers may proceed with reviewing that PR directly.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Consumer page protocol tags lose their color: PROTOCOL_MAP keyed by values the API never sends [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #4742:
URL: https://github.com/apache/rocketmq-dashboard/issues/4742#issuecomment-5761049945

   Resolved by #4741 (merged into rocketmq-studio as 552409185).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org