You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2009/05/01 00:47:30 UTC
[jira] Created: (HBASE-1360) move up to Thrift 0.1
move up to Thrift 0.1
---------------------
Key: HBASE-1360
URL: https://issues.apache.org/jira/browse/HBASE-1360
Project: Hadoop HBase
Issue Type: Improvement
Components: thrift
Reporter: Andrew Purtell
Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801317#action_12801317 ]
Kay Kay commented on HBASE-1360:
--------------------------------
The latest trunk seems to contains commons-lang as well ( in addition to slf4j )
<dependency org="commons-lang" name="commons-lang" rev="2.4" conf="* -> *,!sources,!javadoc"/>
Should that be added explicitly as well ?
Also the 'changing="true"' does not need to be present for these dependencies, since these are static with well-defined release process.
That is mainly reserved for hadoop-core/hdfs/mapred at this point using maven .snapshot symlink for their repositories.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Attachments: hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802076#action_12802076 ]
stack commented on HBASE-1360:
------------------------------
If it is no bother to you, please attach a patch w/ generated classes. Else I'll have a go at it. The current generated classes have an apache license. Is this just mod of a template? Good on you Lars.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-1360:
--------------------------------
Description: Move HBase thrift bits up to Thrift 0.2.0 when it is released. (was: Move HBase thrift bits up to Thrift 0.1 when it is released.)
Affects Version/s: 0.21.0
Summary: move up to Thrift 0.2.0 (was: move up to Thrift 0.1)
I've renamed the issue as per your suggestion.
As Kay Kay has done a wonderful job on THRIFT-363 I think it's best that we wait until that is resolved or at least until Kay Kays latest comment is answered. If they decide to publish 0.2.0 too we can simplify this and need not check in the new .jar file.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.1
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-1360:
----------------------------------
Fix Version/s: 0.20.0
Do for 0.20.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Fix For: 0.20.0
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801514#action_12801514 ]
Kay Kay commented on HBASE-1360:
--------------------------------
{quote}
Hmm... OK. Do I need to update the thrift jar? Or just keep what we currently have checked in to the lib dir?
{quote}
I am not very familiar with hbase-thrift integration details . Lars - you have a suggestion for the process ?
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711721#action_12711721 ]
stack commented on HBASE-1360:
------------------------------
We're on the 0.1 trunk of thrift. That good enough to close this issue? (Let HBASE-1369 cover adding 0.1 thrift when released and leave it as it is, not be in the way of 0.20.0?)
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Fix For: 0.20.0
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.1
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-1360:
--------------------------------
Attachment: hbase-1360.patch
As a first step this could be done now.
Unfortunately Thrift 0.2 introduces two new .jar dependencies. SLF4J:
* slf4j-api-1.5.8.jar
* slf4j-simple-1.5.8.jar
As two different Thrift versions can cause problems and the current Thrift API will stay at least for 0.21 we need those dependencies and the new Thrift 0.2 jar in the core dependencies. All three can be removed once thrift moves out of the core and only to contrib.
SLF4J is in the Maven repositories so Ivy should be able to pull those. I've added a patch that adds SLF4J though someone familiar with Ivy should probably check that it's correct. Should I attach the new libthrift-0.2.0.jar to this ticket as well? It can be generated easily from the thrift release http://incubator.apache.org/thrift/download/
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Attachments: hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801989#action_12801989 ]
stack commented on HBASE-1360:
------------------------------
I need to regenerate thrift classes before I can apply this or do you want to add a patch that removes the old generated code and adds the new? Also, Lars, do you want to update this doc. of the thrift package especially since you have fancy new options: http://hadoop.apache.org/hbase/docs/r0.20.2/api/org/apache/hadoop/hbase/thrift/package-summary.html#package_description?
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801489#action_12801489 ]
stack commented on HBASE-1360:
------------------------------
@Lars and Kay Kay, so you want me to apply this last patch to TRUNK? It moves us to thrift 0.2 (Should we rename this issue?).
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.1
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1360:
-------------------------
Fix Version/s: 0.21.0
Assignee: Kay Kay
Status: Patch Available (was: Open)
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.1
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kay Kay updated HBASE-1360:
---------------------------
Attachment: HBASE-1360.patch
HBASE-1360 with changes attached again.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790167#action_12790167 ]
Lars Francke commented on HBASE-1360:
-------------------------------------
Thrift 0.2.0 has just been released. I'd like to upgrade to this version while doing HBASE-1744.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801428#action_12801428 ]
Lars Francke commented on HBASE-1360:
-------------------------------------
Thanks a lot for the help! I just copied the other <dependency> declarations - thanks for fixing this.
You are also correct about commons-lang. It is used solely for the generation/implementation of proper hashcode functions for the generated types so it is optional but I think it is a good idea to have it. Thanks for catching this.
Everything seems to work just fine with your latest patch!
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-1360:
--------------------------------
Attachment: (was: hbase-1360.patch)
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-1360:
--------------------------------
Attachment: hbase-1360-generated.patch
This is a patch against the current trunk to bring the generated Thrift classes up to version 0.2.0 of Thrift. I've added the Apache license header to every file.
I've also updated the relevant parts of the package documentation for now. The only thing that has changed is that the structs now implement a proper hashcode function.
Other improvements to the old Thrift API will come in a separate issue.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: hbase-1360-generated.patch, HBASE-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated HBASE-1360:
--------------------------------
Attachment: libthrift-0.2.0.jar
I've attached the new libthrift-0.2.0.jar which should replace the old libthrift-r771587.jar in the lib/ directory. This will only work though if the additional dependencies from Kay Kays latest patch are added too.
Should hopefully be okay because Thrift is released under the Apache License as well.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801318#action_12801318 ]
Kay Kay commented on HBASE-1360:
--------------------------------
while we are at this - I have put a patch at THRIFT-363 to help to publish to mvn repositories. That should help us handle tasks like this relatively easy. Interested people can vote on the patch to help that process moving along. Thanks.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Attachments: hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802053#action_12802053 ]
Lars Francke commented on HBASE-1360:
-------------------------------------
I can attach a patch with the regenerated classes - do generated classes need the Apache license header too?
I'll update the doc too but I'll do that in another patch. Let's keep this solely for the Thrift update. I'll have a look if there is an appropriate ticket already or open a new one.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790279#action_12790279 ]
stack commented on HBASE-1360:
------------------------------
+1 Lars
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.2.0
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1360:
-------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
All tests pass. Committed to TRUNK. Great work lads (Lars Francke and Kay Kay).
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: hbase-1360-generated.patch, HBASE-1360.patch, libthrift-0.2.0.jar
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1360) move up to Thrift 0.1
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-1360:
----------------------------------
Fix Version/s: (was: 0.20.0)
Move out of 0.20.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801510#action_12801510 ]
stack commented on HBASE-1360:
------------------------------
Hmm... OK. Do I need to update the thrift jar? Or just keep what we currently have checked in to the lib dir?
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.1
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801322#action_12801322 ]
Kay Kay commented on HBASE-1360:
--------------------------------
@Lars - can you help check the patch once again.
> move up to Thrift 0.1
> ---------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Andrew Purtell
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.1 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801509#action_12801509 ]
Kay Kay commented on HBASE-1360:
--------------------------------
{quote}
@Lars and Kay Kay, so you want me to apply this last patch to TRUNK? It moves us to thrift 0.2 (Should we rename this issue?).
{quote}
I am ok with applying this patch to trunk and keep this ball rolling. THRIFT-363 - a good chunk of it is done - but it is going to be sometime before the thrift dev decides on a release process / build etc.
After it is done - we can always create another patch to remove thrift from ivy.xml altogether and integrate. So for now - green with this patch and go ahead please.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1360) move up to Thrift 0.2.0
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801499#action_12801499 ]
stack commented on HBASE-1360:
------------------------------
@Lars Francke -- sounds like a good tactic to me.
> move up to Thrift 0.2.0
> -----------------------
>
> Key: HBASE-1360
> URL: https://issues.apache.org/jira/browse/HBASE-1360
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Andrew Purtell
> Assignee: Kay Kay
> Fix For: 0.21.0
>
> Attachments: HBASE-1360.patch, hbase-1360.patch
>
>
> Move HBase thrift bits up to Thrift 0.2.0 when it is released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.