You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/15 15:28:59 UTC
[GitHub] [arrow] pitrou opened a new pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
pitrou opened a new pull request #11961:
URL: https://github.com/apache/arrow/pull/11961
Some compute function have required options (because there is no reasonable default value).
Currently they would raise a cryptic error:
```
>>> pc.partition_nth_indices([1,2,3])
Traceback (most recent call last):
...
ArrowInvalid: Attempted to initialize KernelState from null FunctionOptions
```
With this PR, the error becomes slightly more insightful:
```
>>> pc.partition_nth_indices([1,2,3])
Traceback (most recent call last):
...
ArrowInvalid: Function 'partition_nth_indices' cannot be called without options
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11961:
URL: https://github.com/apache/arrow/pull/11961#issuecomment-996145829
Benchmark runs are scheduled for baseline = 049118f50ce46bf837de7bbb55486e74a9dc9e5d and contender = 5e00e70c6ed5ab48fe32042f405f2db4c61f6869. 5e00e70c6ed5ab48fe32042f405f2db4c61f6869 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff512957afb24089886a7fdffdafc167...d35cefade8ff4efd905a4993b8df27d9/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93bf228919564f7eac773bce37eb2a56...72c124063f9f49e9b21cb75ba8f8bbb1/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9808c7324b744b09b41dce9bbe8e0bfb...80c2c74d14a0450c944443d4cc660868/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11961:
URL: https://github.com/apache/arrow/pull/11961#issuecomment-994902457
Based on PR #11955.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #11961:
URL: https://github.com/apache/arrow/pull/11961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11961:
URL: https://github.com/apache/arrow/pull/11961#issuecomment-994902831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11961:
URL: https://github.com/apache/arrow/pull/11961#issuecomment-996145829
Benchmark runs are scheduled for baseline = 049118f50ce46bf837de7bbb55486e74a9dc9e5d and contender = 5e00e70c6ed5ab48fe32042f405f2db4c61f6869. 5e00e70c6ed5ab48fe32042f405f2db4c61f6869 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff512957afb24089886a7fdffdafc167...d35cefade8ff4efd905a4993b8df27d9/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93bf228919564f7eac773bce37eb2a56...72c124063f9f49e9b21cb75ba8f8bbb1/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9808c7324b744b09b41dce9bbe8e0bfb...80c2c74d14a0450c944443d4cc660868/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11961:
URL: https://github.com/apache/arrow/pull/11961#issuecomment-996145829
Benchmark runs are scheduled for baseline = 049118f50ce46bf837de7bbb55486e74a9dc9e5d and contender = 5e00e70c6ed5ab48fe32042f405f2db4c61f6869. 5e00e70c6ed5ab48fe32042f405f2db4c61f6869 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff512957afb24089886a7fdffdafc167...d35cefade8ff4efd905a4993b8df27d9/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93bf228919564f7eac773bce37eb2a56...72c124063f9f49e9b21cb75ba8f8bbb1/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9808c7324b744b09b41dce9bbe8e0bfb...80c2c74d14a0450c944443d4cc660868/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11961: ARROW-14853: [C++][Python] Improve error message for missing function options
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11961:
URL: https://github.com/apache/arrow/pull/11961#issuecomment-996145829
Benchmark runs are scheduled for baseline = 049118f50ce46bf837de7bbb55486e74a9dc9e5d and contender = 5e00e70c6ed5ab48fe32042f405f2db4c61f6869. 5e00e70c6ed5ab48fe32042f405f2db4c61f6869 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff512957afb24089886a7fdffdafc167...d35cefade8ff4efd905a4993b8df27d9/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/93bf228919564f7eac773bce37eb2a56...72c124063f9f49e9b21cb75ba8f8bbb1/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9808c7324b744b09b41dce9bbe8e0bfb...80c2c74d14a0450c944443d4cc660868/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org