You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/14 17:12:53 UTC

[GitHub] [druid] a2l007 opened a new pull request #9365: Fix compatibility issues with SqlFirehose

a2l007 opened a new pull request #9365: Fix compatibility issues with SqlFirehose
URL: https://github.com/apache/druid/pull/9365
 
 
   <!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
   
   Fixes #9359.
   
   <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
   
   <!-- If you are a committer, follow the PR action item checklist for committers:
   https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
   
   ### Description
   
   `SqlFirehoseFactory` is now fixed to be compatible with the deprecated `FiniteFirehoseFactory` . Will look to add `InputSource` and `InputFormat` support soon.
   <!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
   
   <!-- Describe your patch: what did you change in code? How did you fix the problem? -->
   
   <!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
    - Method organization and design (how the logic is split between methods, parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jihoonson commented on issue #9365: Fix compatibility issues with SqlFirehose

Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9365: Fix compatibility issues with SqlFirehose
URL: https://github.com/apache/druid/pull/9365#issuecomment-586484839
 
 
   Would you fix the TC failure?
   
   ![Screen Shot 2020-02-14 at 1 44 13 PM](https://user-images.githubusercontent.com/2322288/74569797-1fdfb300-4f30-11ea-91bb-31d2f4f396f1.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] a2l007 commented on issue #9365: Fix compatibility issues with SqlFirehose

Posted by GitBox <gi...@apache.org>.
a2l007 commented on issue #9365: Fix compatibility issues with SqlFirehose
URL: https://github.com/apache/druid/pull/9365#issuecomment-592001425
 
 
   Hi @MoushmiDas ,the fix for this is merged to master and so unfortunately it is unavailable with the 0.17.0 release. You could however build druid from source with the master branch. Instructions here: https://druid.apache.org/docs/latest/development/build.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jihoonson merged pull request #9365: Fix compatibility issues with SqlFirehose

Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9365: Fix compatibility issues with SqlFirehose
URL: https://github.com/apache/druid/pull/9365
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] MoushmiDas edited a comment on issue #9365: Fix compatibility issues with SqlFirehose

Posted by GitBox <gi...@apache.org>.
MoushmiDas edited a comment on issue #9365: Fix compatibility issues with SqlFirehose
URL: https://github.com/apache/druid/pull/9365#issuecomment-591823095
 
 
   Hi Team,
   
   I am trying to Load the data from Postgresql to Apache Druid(apache-druid-0.17.0) , but I am getting below error:
   
   "SQL firehose error with org.apache.druid.segment.realtime.firehose.SqlFirehoseFactory cannot be cast to org.apache.druid.data.input.FiniteFirehoseFactory."
   
   seems the issue is already resolve in the below  Ticket request:
   
   *SQL firehose error #9359
   *Fix compatibility issues with SqlFirehose #9365
   
   Could you please help me to get the new io-configuration for the postgresql.
   
   Currently we are using below io-config for which we are getting above error:
       "ioConfig": {
         "type": "index",
         "firehose": {
           "type": "sql",
           "database": {
             "type": "postgresql",
             "connectorConfig": {
              "connectURI": "jdbc:postgresql://<Host_Name>:<PortNo.>/<DB_Name>",
   			"user": "<User_Name>",
               "password": "<Pass_word>"
                }
           },
           "sqls": [
             "select * from Table;"
           ]
         }
       }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] MoushmiDas commented on issue #9365: Fix compatibility issues with SqlFirehose

Posted by GitBox <gi...@apache.org>.
MoushmiDas commented on issue #9365: Fix compatibility issues with SqlFirehose
URL: https://github.com/apache/druid/pull/9365#issuecomment-591823095
 
 
   
   Hi Team,
   
   I am trying to Load the data from Postgresql to Apache Druid(apache-druid-0.17.0) , but I am getting below error:
   
   "SQL firehose error with org.apache.druid.segment.realtime.firehose.SqlFirehoseFactory cannot be cast to org.apache.druid.data.input.FiniteFirehoseFactory."
   
   seems the issue is already resolve in the below  Ticket request:
   
   *SQL firehose error #9359
   *Fix compatibility issues with SqlFirehose #9365
   
   Could you please help me to get the new io-configuration for the postgresql.
   
   Currently we are using below io-config for which we are getting above error:
       "ioConfig": {
         "type": "index",
         "firehose": {
           "type": "sql",
           "database": {
             "type": "postgresql",
             "connectorConfig": {
              "connectURI": "jdbc:postgresql://<HostName>:<PortNo.>/<DB_Name>",
   			"user": "<UserName>",
               "password": "<Password>"
                }
           },
           "sqls": [
             "select * from Table;"
           ]
         }
       }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org