svn commit: r1468780 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/mail/MimeMessageWrapper.java

[jl...@apache.org]

Author: jleroux
Date: Wed Apr 17 07:23:03 2013
New Revision: 1468780

URL: http://svn.apache.org/r1468780
Log:
A patch from Shi Jinghai for "Remove warning message "No converter found, converting from org.ofbiz.service.mail.MimeMessageWrapper to java.lang.String" https://issues.apache.org/jira/browse/OFBIZ-5180

When sending emails, there are warning messages in log:
2012-10-09 16:07:20,100 (default-invoker-Thread-9) [ Converters.java:102:WARN ] *** No converter found, converting from org.ofbiz.service.mail.MimeMessageWrapper to java.lang.String. Please report this message to the developer community so a suitable converter can be created. ***
2012-10-09 16:07:20,101 (default-invoker-Thread-9) [ ObjectType.java:540:WARN ] No special conversion available for org.ofbiz.service.mail.MimeMessageWrapper to String, returning object.toString().

I added a MimeMessageToString converter in MimeMessageWrapper.java to resolve this problem.


Modified:
    ofbiz/trunk/framework/service/src/org/ofbiz/service/mail/MimeMessageWrapper.java

Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/mail/MimeMessageWrapper.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/mail/MimeMessageWrapper.java?rev=1468780&r1=1468779&r2=1468780&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/org/ofbiz/service/mail/MimeMessageWrapper.java (original)
+++ ofbiz/trunk/framework/service/src/org/ofbiz/service/mail/MimeMessageWrapper.java Wed Apr 17 07:23:03 2013
@@ -38,6 +38,9 @@ import javax.mail.internet.MimeMessage;
 
 import javolution.util.FastList;
 
+import org.ofbiz.base.conversion.AbstractConverter;
+import org.ofbiz.base.conversion.ConversionException;
+import org.ofbiz.base.conversion.Converters;
 import org.ofbiz.base.util.Debug;
 import org.ofbiz.base.util.GeneralRuntimeException;
 import org.ofbiz.base.util.UtilDateTime;
@@ -544,4 +547,22 @@ public class MimeMessageWrapper implemen
 
         return ByteBuffer.wrap(baos.toByteArray());
     }
+
+    static {
+        Converters.registerConverter(new MimeMessageToString<String>());
+    }
+
+    /**
+     * Convert MimeMessageWrapper to String. This is used when sending emails.
+     * 
+     */
+    private static class MimeMessageToString<E> extends AbstractConverter<MimeMessageWrapper, String> {
+        public MimeMessageToString() {
+            super(MimeMessageWrapper.class, String.class);
+        }
+
+        public String convert(MimeMessageWrapper obj) throws ConversionException {
+            return obj.toString();
+        }
+    }
 }