You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2008/04/17 21:08:12 UTC
Re: svn commit: r649173 - /apr/apr/trunk/include/arch/win32/apr_arch_misc.h
mturk@apache.org wrote:
> Author: mturk
> Date: Thu Apr 17 09:27:10 2008
> New Revision: 649173
>
> Fix NtXXX prototypes. They are all declared as NTSTATUS(LONG) not DWORD
Before you let this ride, are you /certain/ this doesn't break older 2003
compilers? I'm betting it might... :(
I'll test on my return.
Bill
Re: svn commit: r649173 - /apr/apr/trunk/include/arch/win32/apr_arch_misc.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
>
> It works perfectly with VS6
Cool, then feel free to apply to 1.3.x branch, of course.
Re: svn commit: r649173 - /apr/apr/trunk/include/arch/win32/apr_arch_misc.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
>
> It works perfectly with VS6
Cool, then feel free to apply to 1.3.x branch, of course.
Re: svn commit: r649173 - /apr/apr/trunk/include/arch/win32/apr_arch_misc.h
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> mturk@apache.org wrote:
>> Author: mturk
>> Date: Thu Apr 17 09:27:10 2008
>> New Revision: 649173
>>
>> Fix NtXXX prototypes. They are all declared as NTSTATUS(LONG) not DWORD
>
> Before you let this ride, are you /certain/ this doesn't break older 2003
> compilers? I'm betting it might... :(
>
Those are function prototypes declared to return NTSTATUS which
OTOH was always defined as LONG and not as DWORD.
In essence LONG is long, DWORD is unsigned long.
The reason is because kernel functions usually report
return values as failed with NTSTATUS < 0, success as 0 or >= 0.
> I'll test on my return.
>
It works perfectly with VS6
Regards
--
(TM)
Re: svn commit: r649173 - /apr/apr/trunk/include/arch/win32/apr_arch_misc.h
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> mturk@apache.org wrote:
>> Author: mturk
>> Date: Thu Apr 17 09:27:10 2008
>> New Revision: 649173
>>
>> Fix NtXXX prototypes. They are all declared as NTSTATUS(LONG) not DWORD
>
> Before you let this ride, are you /certain/ this doesn't break older 2003
> compilers? I'm betting it might... :(
>
Those are function prototypes declared to return NTSTATUS which
OTOH was always defined as LONG and not as DWORD.
In essence LONG is long, DWORD is unsigned long.
The reason is because kernel functions usually report
return values as failed with NTSTATUS < 0, success as 0 or >= 0.
> I'll test on my return.
>
It works perfectly with VS6
Regards
--
(TM)