You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lburgazzoli (via GitHub)" <gi...@apache.org> on 2023/08/04 13:59:14 UTC
[GitHub] [camel] lburgazzoli opened a new pull request, #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
lburgazzoli opened a new pull request, #11006:
URL: https://github.com/apache/camel/pull/11006
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667548650
All the dev consoles uses it as well, see core/camel-console
And mind that if you have some text then you can use the escape method to make it json safe (but you very likely do not need that, we use it to dump source code in json etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667522233
> Should
>
> ```
> "deprecated" : "false",
> ```
>
> Not be a json boolean type (according to spec) ???
>
> ```
> "deprecated" : false,
> ```
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1666896698
@lburgazzoli you have some commits in this PR from seda and others that are not related. Maybe you can rebase and update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667469858
The order of type, description, title, etc seems to not be strict/consistent. I wonder if we can make it the same order everywhere. Sometimes description is before title, and other times its after etc.
This file will be regen more often when we fix typo, add new option, change a default etc. So it would be good to ensure the generator is 100% on all OS (not like. that XML XSD that is a bit of a pain)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667910030
ok, I think now the PR is now ready.
I did some investigation for https://issues.apache.org/jira/browse/CAMEL-19717 but I found that there is an issue with escaping https://issues.apache.org/jira/browse/CAMEL-19718 which seems not super easy to fix if we want to preserve the option to escapes forward slashes.
I will digg into that a little bit more in the coming days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667576830
> Its likely a bunch of work to change so maybe create a JIRA ticket and put it as v4.1.
https://issues.apache.org/jira/browse/CAMEL-19717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667537634
Hmm jackson still dumps it in different order. They should use a linked map so the values are in the order they are added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667550445
I mean, an example of a unordered property :)
But I think I got it so basically there were a discrepancy in the order the properties were set for types and related properties but Jackson did serialize them according to the insertion order. It should be fixed now.
I'll try to use camel-util-json later as it would mean changing a number of things now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667547073
https://github.com/apache/camel/blob/3907d9991010aa7cbda1a8bb1f647911458a6cac/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/BacklogTracer.java#L350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667282632
@davsclaus done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1669328662
LGTM
@lburgazzoli we need to merge this today so it has time to get into 4.0 GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1665656163
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667467439
Should
"deprecated" : "false",
Not be a json boolean type (according to spec) ???
"deprecated" : false,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667524816
> The order of type, description, title, etc seems to not be strict/consistent. I wonder if we can make it the same order everywhere. Sometimes description is before title, and other times its after etc.
I have changed the json schema generation to be consistent, at least with what Jackson's ObjectMapper allows to configure. Let me know if you spot any inconsistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667542001
> Hmm jackson still dumps it in different order. They should use a linked map so the values are in the order they are added.
can you give me an example ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1666912519
oh damn, I thought I had removed them, will rebase tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667476771
@davsclaus let me have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667550075
Its likely a bunch of work to change so maybe create a JIRA ticket and put it as v4.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11006:
URL: https://github.com/apache/camel/pull/11006#issuecomment-1667540204
Our own library `camel-util-json` has a basic JsonObject / JsonArray which is consistent. And `JSooner` has prettyPrint methods to dump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] lburgazzoli merged pull request #11006: [CAMEL-19709] yaml dsl: include additional information such as description and title in the jscon schema
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli merged PR #11006:
URL: https://github.com/apache/camel/pull/11006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org