[jira] [Updated] (MESOS-6320) Implement clang-tidy check to catch incorrect flags hierarchies

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bannier updated MESOS-6320:
------------------------------------
    Shepherd: Michael Park

> Implement clang-tidy check to catch incorrect flags hierarchies
> ---------------------------------------------------------------
>
>                 Key: MESOS-6320
>                 URL: https://issues.apache.org/jira/browse/MESOS-6320
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Bannier
>            Assignee: Benjamin Bannier
>              Labels: clang-tidy, mesosphere
>
> Classes need to always use {{virtual}} inheritance when being derived from {{FlagsBase}}. Also, in order to compose such derived flags they should be inherited virtually again.
> Some examples:
> {code}
> struct A : virtual FlagsBase {}; // OK
> struct B : FlagsBase {}; // ERROR
> struct C : A {}; // ERROR
> {code}
> We should implement a clang-tidy checker to catch such wrong inheritance issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)