You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/20 16:01:41 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request #2572: sysview: Fix build for c++

kasjer opened a new pull request #2572:
URL: https://github.com/apache/mynewt-core/pull/2572


   Initializing non-const char pointer with constant string literal
   is an error in c++ according to g++ compiler.
   `error: ISO C++ forbids converting a string constant to 'char*' [-Werror=write-strings]
   `
   This assignment even for c build is not useful since
   _asprintf_ assigns new value (possible NULL) to **desc** anyway.
   
   This change just drops meaningless initialization that makes g++ unhappy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2572: sysview: Fix build for c++

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2572:
URL: https://github.com/apache/mynewt-core/pull/2572#issuecomment-823415668


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer merged pull request #2572: sysview: Fix build for c++

Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2572:
URL: https://github.com/apache/mynewt-core/pull/2572


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org