[PR] Fix: Replace std::floating_point concept with std::is_floating_point_v for Apple Clang 14.0.0 compatibility [arrow]

["shashbha14 (via GitHub)" <gi...@apache.org>]

shashbha14 opened a new pull request, #49182:
URL: https://github.com/apache/arrow/pull/49182

   This fixes the CRAN build failure on macOS 13.3 with Apple Clang 14.0.0.
   
   The problem is that `std::floating_point<T>` is a C++20 concept, but Apple Clang 14.0.0 doesn't have full support for it yet. When building, it errors out saying it can't find `floating_point` in the `std` namespace.
   
   I swapped it out for `std::is_floating_point_v<T>` instead, which is basically the same thing but uses a C++17 variable template that works fine with older compilers. I also added `#include <type_traits>` since that's where `is_floating_point_v` lives.
   
   Behavior is unchanged - still matches all the floating point types (float, double, long double) plus util::Float16. Just using a different approach that the older compiler can handle.
   
   Fixes #49176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Replace std::floating_point concept with std::is_floating_point_v for Apple Clang 14.0.0 compatibility [arrow]

["raulcd (via GitHub)" <gi...@apache.org>]

raulcd closed pull request #49182:    Fix: Replace std::floating_point concept with std::is_floating_point_v for Apple Clang 14.0.0 compatibility
URL: https://github.com/apache/arrow/pull/49182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Replace std::floating_point concept with std::is_floating_point_v for Apple Clang 14.0.0 compatibility [arrow]

["kou (via GitHub)" <gi...@apache.org>]

kou commented on PR #49182:
URL: https://github.com/apache/arrow/pull/49182#issuecomment-3868691702

   Could you use our PR template instead of removing it entirely?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Replace std::floating_point concept with std::is_floating_point_v for Apple Clang 14.0.0 compatibility [arrow]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #49182:
URL: https://github.com/apache/arrow/pull/49182#issuecomment-3867037097

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org