You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/09/30 13:34:34 UTC

[GitHub] [tinkerpop] jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error

jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error
URL: https://github.com/apache/tinkerpop/pull/1202#issuecomment-536563171
 
 
   Thanks @gion for looking into this!
   
   It's a good idea to expose a way to subscribe to connection events.
   
   In the case of errors, I think it would be best to avoid [emitting `'error'` events](https://github.com/apache/tinkerpop/blob/3.4.3/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L216) and instead use `'socketError'`, that way we don't default to an uncaught error when the user is not listening to the `'error'` event, wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services