You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "liqingwang (via GitHub)" <gi...@apache.org> on 2023/02/07 03:07:17 UTC

[GitHub] [dolphinscheduler] liqingwang opened a new issue, #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

liqingwang opened a new issue, #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   For now, data quality only supports a single rule for one job, and for our real scenes to be used, one job needs to check a lot of fields. So we want to support multiple rules for one data quality job.
   
   ### Use case
   
   We will change the data quality task definition page to a table and then can add a lot of rules and crud, below are the demo design:
   <img width="1727" alt="定义任务" src="https://user-images.githubusercontent.com/20885366/217137636-91757449-8fd3-45c8-86fd-ff343fe1479b.png">
   ![新建规则](https://user-images.githubusercontent.com/20885366/217137647-1dfa1ab7-c75c-4bea-b9ed-78bfc8bac449.jpeg)
   ![组合页面](https://user-images.githubusercontent.com/20885366/217137826-94f62fa1-15c0-48a2-9643-d87c2671eb3a.png)
   
   
   And we will change the data quality result page to support a result with multiple rules, below is the demo design:
   
   <img width="1727" alt="任务结果" src="https://user-images.githubusercontent.com/20885366/217137869-3943ac25-379c-46f7-80ec-2ea8302363e4.png">
   <img width="1727" alt="任务明细" src="https://user-images.githubusercontent.com/20885366/217137873-9ba5d1f7-6978-4801-890b-cac742ef5cf8.png">
   
   
   
   ### Related issues
   
   Enhance https://github.com/apache/dolphinscheduler/issues/4283
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-1420131442

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   For now, data quality only supports a single rule for one job, and for our real scenes to be used, one job needs to check a lot of fields. So we want to support multiple rules for one data quality job.
   
   ### Use case
   
   We will change the data quality task definition page to a table and then can add a lot of rules and crud, below are the demo design:
   <img width="1727" alt="定义任务" src="https://user-images.githubusercontent.com/20885366/217137636-91757449-8fd3-45c8-86fd-ff343fe1479b.png">
   ![新建规则](https://user-images.githubusercontent.com/20885366/217137647-1dfa1ab7-c75c-4bea-b9ed-78bfc8bac449.jpeg)
   ![组合页面](https://user-images.githubusercontent.com/20885366/217137826-94f62fa1-15c0-48a2-9643-d87c2671eb3a.png)
   
   
   And we will change the data quality result page to support a result with multiple rules, below is the demo design:
   
   <img width="1727" alt="任务结果" src="https://user-images.githubusercontent.com/20885366/217137869-3943ac25-379c-46f7-80ec-2ea8302363e4.png">
   <img width="1727" alt="任务明细" src="https://user-images.githubusercontent.com/20885366/217137873-9ba5d1f7-6978-4801-890b-cac742ef5cf8.png">
   
   
   
   ### Related issues
   
   Enhance https://github.com/apache/dolphinscheduler/issues/4283
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-1420131607

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature][Data Quality] Data Quality Job Support Multiple Rules [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules 
URL: https://github.com/apache/dolphinscheduler/issues/13524


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature][Data Quality] Data Quality Job Support Multiple Rules [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-2436566868

   This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature][Data Quality] Data Quality Job Support Multiple Rules [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-2420927450

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] liujinhui1994 commented on issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

Posted by "liujinhui1994 (via GitHub)" <gi...@apache.org>.
liujinhui1994 commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-1586742144

   @liqingwang Is there a PR for this now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] zhongjiajie commented on issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-1420490212

   Good idea, it is a sweet feature and I like it. looking forward your contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] liujinhui1994 commented on issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

Posted by "liujinhui1994 (via GitHub)" <gi...@apache.org>.
liujinhui1994 commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-1586738786

   @liqingwang hi,where is this going?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] liqingwang commented on issue #13524: [Feature][Data Quality] Data Quality Job Support Multiple Rules

Posted by "liqingwang (via GitHub)" <gi...@apache.org>.
liqingwang commented on issue #13524:
URL: https://github.com/apache/dolphinscheduler/issues/13524#issuecomment-1586804104

   Hi @liujinhui1994 , Sorry for the later reply,  It's still working, some work things have higher priority, will take 1-2 months


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org