[GitHub] [pulsar] sijie commented on a change in pull request #5713: avoid unsafe split when validate hostname which might be ipv6 address

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #5713: avoid unsafe split when validate hostname which might be ipv6 address
URL: https://github.com/apache/pulsar/pull/5713#discussion_r350864806
 
 

 ##########
 File path: pulsar-common/src/test/java/org/apache/pulsar/common/net/ServiceURITest.java
 ##########
 @@ -122,6 +122,18 @@ public void testUserInfo() {
             "/path/to/namespace");
     }
 
+    @Test
+    public void testIpv6Uri() {
 
 Review comment:
   Can you add a test case of using ipv6 address without port?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services