(kafka) branch 3.8 updated: MINOR: Fix broken ReassignPartitionsCommandTest test (#16251)

[so...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

soarez pushed a commit to branch 3.8
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/3.8 by this push:
     new a8316f442ad MINOR: Fix broken ReassignPartitionsCommandTest test (#16251)
a8316f442ad is described below

commit a8316f442ad0e35d1e89a7d11011d6fabdd4aa24
Author: Igor Soarez <i...@soarez.me>
AuthorDate: Sat Jun 8 14:06:46 2024 +0300

    MINOR: Fix broken ReassignPartitionsCommandTest test (#16251)
    
    KAFKA-16606 (#15834) introduced a change that broke
    ReassignPartitionsCommandTest.testReassignmentCompletionDuringPartialUpgrade.
    
    The point was to validate that the MetadataVersion supports JBOD
    in KRaft when multiple log directories are configured.
    We do that by checking the version used in
    kafka-features.sh upgrade --metadata, and the version discovered
    via a FeatureRecord for metadata.version in the cluster metadata.
    
    There's no point in checking inter.broker.protocol.version in
    KafkaConfig, since in KRaft, that configuration is deprecated
    and ignored — always assuming the value of MINIMUM_KRAFT_VERSION.
    
    The broken that was broken sets inter.broker.protocol.version in
    KRaft mode and configures 3 directories. So alternatively, we
    could change the test to not configure this property.
    Since the property isn't forbidden in KRaft mode, just ignored,
    and operators may forget to remove it, it seems better to remote
    the fail condition in KafkaConfig.
    
    Reviewers: Luke Chen <sh...@gmail.com>
---
 core/src/main/scala/kafka/server/KafkaConfig.scala | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala
index f23bf349181..b812f299ecb 100755
--- a/core/src/main/scala/kafka/server/KafkaConfig.scala
+++ b/core/src/main/scala/kafka/server/KafkaConfig.scala
@@ -1365,14 +1365,6 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami
       }
       validateAdvertisedListenersNonEmptyForBroker()
     }
-    if (processRoles.contains(ProcessRole.BrokerRole)
-      && originals.containsKey(ReplicationConfigs.INTER_BROKER_PROTOCOL_VERSION_CONFIG)
-      && logDirs.size > 1) {
-        require(interBrokerProtocolVersion.isDirectoryAssignmentSupported,
-          s"Multiple log directories (aka JBOD) are not supported with the configured " +
-            s"${interBrokerProtocolVersion} ${ReplicationConfigs.INTER_BROKER_PROTOCOL_VERSION_CONFIG}. " +
-            s"Need ${MetadataVersion.IBP_3_7_IV2} or higher")
-    }
 
     val listenerNames = listeners.map(_.listenerName).toSet
     if (processRoles.isEmpty || processRoles.contains(ProcessRole.BrokerRole)) {