You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2010/05/08 06:40:52 UTC
svn commit: r942307 -
/myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
Author: lu4242
Date: Sat May 8 04:40:52 2010
New Revision: 942307
URL: http://svn.apache.org/viewvc?rev=942307&view=rev
Log:
small optimization only create array when necessary
Modified:
myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
Modified: myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java?rev=942307&r1=942306&r2=942307&view=diff
==============================================================================
--- myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java (original)
+++ myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java Sat May 8 04:40:52 2010
@@ -2386,7 +2386,7 @@ public final class HtmlRendererUtils {
public static List<UIParameter> getValidUIParameterChildren(FacesContext facesContext,
List<UIComponent> children, boolean skipNullValue, boolean skipUnrendered, boolean skipNullName)
{
- List<UIParameter> params = new ArrayList<UIParameter>();
+ List<UIParameter> params = null;
for (UIComponent child : children)
{
@@ -2428,10 +2428,18 @@ public final class HtmlRendererUtils {
}
// add the param
+ if (params == null)
+ {
+ params = new ArrayList<UIParameter>();
+ }
params.add(param);
}
}
-
+
+ if (params == null)
+ {
+ params = Collections.emptyList();
+ }
return params;
}