[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #481: [FLINK-30361] Cluster deleted and created back while updating replicas

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #481:
URL: https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1046138658


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -171,11 +170,6 @@ protected void deleteClusterInternal(ObjectMeta meta, boolean deleteHaConfigmaps
 
     @Override
     public boolean scale(ObjectMeta meta, JobSpec jobSpec, Configuration conf) {
-        if (conf.get(JobManagerOptions.SCHEDULER_MODE) == null) {

Review Comment:
   This check was supposed to check whether reactive scheduler is enabled for applications, we can’t simply remove it.
   
   Maybe we are lacking test coverage for this…
   
   In any case it checks not null which already looks incorrect. @morhidi you worked on this in the past what do you think?



##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/SessionReconciler.java:
##########
@@ -96,6 +96,19 @@ protected void reconcileSpecChange(
             Configuration deployConfig,
             DiffType type)
             throws Exception {
+        if (type == DiffType.SCALE) {

Review Comment:
   If this logic is the same as the one in the AbstracJobReconciler we should move it instead to the shared parent class (AbstractFlinkResourceRecnciler)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org