You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "uyivzola (via GitHub)" <gi...@apache.org> on 2026/09/09 17:35:54 UTC
[PR] fix(filters): warn about empty time ranges [superset]
uyivzola opened a new pull request, #44099:
URL: https://github.com/apache/superset/pull/44099
### SUMMARY
The time-range picker now warns when the evaluated start and end are identical, explaining why the range returns no rows. Apply stays available after evaluation; correcting the range clears the warning. Stale responses cannot overwrite the edited range.
Fixes #42679.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: identical endpoints were accepted without an explanation.
After: βThis time range is empty. Choose an end time later than the start time.β
Before/after screenshots captured; attachment pending.
### TESTING INSTRUCTIONS
1. In the time-range picker, set both endpoints to `2024-01-01`.
2. Confirm the warning appears and Apply is enabled after evaluation.
3. Change the end to `2024-01-02`; Apply waits for evaluation and the warning clears.
4. Apply using Enter, then select and apply No filter.
Passed locally: 73 focused tests, production frontend build, pre-commit including type checks, and Chrome component checks. Browser checks intercepted the time-range API; no full backend deployment was tested. The build retained four unrelated dependency/bundle warnings.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #42679
- [ ] Required feature flags
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(filters): warn about empty time ranges [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44099:
URL: https://github.com/apache/superset/pull/44099#issuecomment-6421560892
@uyivzola the race-condition guards are nice. It still needs a rebase and the ListView `TimeRange.tsx` plus the time-shift branch to fully close #42679. Want to take those, or should I push them to your branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(filters): warn about empty time ranges [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44099:
URL: https://github.com/apache/superset/pull/44099#issuecomment-5606700120
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44099?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.24390%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.13%. Comparing base ([`70346a5`](https://app.codecov.io/gh/apache/superset/commit/70346a51b6999a6624406a1c801f0fc197947505?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`19dfd80`](https://app.codecov.io/gh/apache/superset/commit/19dfd80acb5d9626fb5156ef682685ecb6288c7e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/44099?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://app.codecov.io/gh/apache/superset/pull/44099?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fexplore%2Fcomponents%2Fcontrols%2FDateFilterControl%2FDateFilterLabel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | 89.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44099 +/- ##
==========================================
+ Coverage 80.09% 80.13% +0.03%
==========================================
Files 2922 2922
Lines 171996 172001 +5
Branches 39911 39921 +10
==========================================
+ Hits 137765 137831 +66
+ Misses 31653 31592 -61
Partials 2578 2578
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44099/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44099/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.64% <90.24%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44099?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(filters): warn about empty time ranges [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44099:
URL: https://github.com/apache/superset/pull/44099#issuecomment-5769650743
This is careful work on the race-condition side (the stale-response guards are a nice catch beyond what the issue even asked for), but I don't think it closes #42679 all the way. `TimeRange.tsx` in `components/ListView/Filters` is a near-identical picker used for the Charts/Datasets list filters, and it does its own raw API call with no since/until equality check at all, so the same silent-empty-range bug is still reproducible there. `fetchTimeRange.ts`'s time-comparison/shift branch is missing the `isEmpty` flag too, so a period-over-period comparison that collapses to an empty range gets no signal either, even in the file this PR patches.
Worth extending to both before marking this ready for review. Holler if you'd like a hand tracking down the other call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(filters): warn about empty time ranges [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44099:
URL: https://github.com/apache/superset/pull/44099#issuecomment-5606145420
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | aaeccb40702c33da789bac23bd623814827de57b |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa198fbd8e807000811e3b3 |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-44099--superset-docs-preview.netlify.app](https://deploy-preview-44099--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpJDoAgDADAv_QssYjR6g98BktdEhVCPECMf7e3OcwLKccrPTADNOCyvf0u9jFwadejqL4bxkmxlKqe42IlZWO5gdMZ6xJkD9bqiVYXiAlHRCSt2TgD3w8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44099--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(filters): warn about empty time ranges [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44099:
URL: https://github.com/apache/superset/pull/44099#issuecomment-5606123097
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org