You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2018/04/17 20:04:00 UTC

[jira] [Created] (BEAM-4103) Invert JavaNature configuration

Kenneth Knowles created BEAM-4103:
-------------------------------------

             Summary: Invert JavaNature configuration
                 Key: BEAM-4103
                 URL: https://issues.apache.org/jira/browse/BEAM-4103
             Project: Beam
          Issue Type: Sub-task
          Components: build-system
            Reporter: Kenneth Knowles


Today the applyJavaNature method demonstrates a significant programming and build config anti-pattern: one giant method with unclear/no spec and some flags to tweak what it does, that can only really be understood by reading its full code.

Instead, best practice would be to separate the functionality controlled by each flag into a block that a module can call. It is not wrong to pass configuration parameters, but in this case that's not really what is going on.

Since the flags are "on by default" and serve to suppress things like findbugs, this just means breaking out the findbugs into a separate bit. We can always also have a convenience three-liner that calls the basics, calls findbugs, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)