You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@giraph.apache.org by ed...@apache.org on 2016/07/19 00:31:04 UTC
git commit: updated refs/heads/release-1.2 to 1fb6a5c
Repository: giraph
Updated Branches:
refs/heads/release-1.2 df8f128e2 -> 1fb6a5c5b
GIRAPH-1097 Fix TestOutOfCore.testOutOfCoreLocalDiskAccessor
Summary:
On my laptop it failed because of an NPE in WorkerSuperstepMetrics.
I tracked it down and found that it is triggered from the branch of code that prints out metrics. We don't normally print out metrics in unit tests, so I'd expect this feature doesn't exist or not functional in hadoop_1. I'll try to disable it, to see how jenkins reacts.
Test Plan: mvn test -pl giraph-examples -am -Dtest=TestOutOfCore -DfailIfNoTests=false -Phadoop_1
Reviewers: maja.kabiljo, dionysis.logothetis, heslami
Reviewed By: heslami
Differential Revision: https://reviews.facebook.net/D60873
Project: http://git-wip-us.apache.org/repos/asf/giraph/repo
Commit: http://git-wip-us.apache.org/repos/asf/giraph/commit/1fb6a5c5
Tree: http://git-wip-us.apache.org/repos/asf/giraph/tree/1fb6a5c5
Diff: http://git-wip-us.apache.org/repos/asf/giraph/diff/1fb6a5c5
Branch: refs/heads/release-1.2
Commit: 1fb6a5c5bcf095045151a7ce7be0c129d4bd06eb
Parents: df8f128
Author: Sergey Edunov <ed...@fb.com>
Authored: Mon Jul 18 17:30:04 2016 -0700
Committer: Sergey Edunov <ed...@fb.com>
Committed: Mon Jul 18 17:30:42 2016 -0700
----------------------------------------------------------------------
.../src/test/java/org/apache/giraph/TestOutOfCore.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/giraph/blob/1fb6a5c5/giraph-examples/src/test/java/org/apache/giraph/TestOutOfCore.java
----------------------------------------------------------------------
diff --git a/giraph-examples/src/test/java/org/apache/giraph/TestOutOfCore.java b/giraph-examples/src/test/java/org/apache/giraph/TestOutOfCore.java
index e497541..a9d6a65 100644
--- a/giraph-examples/src/test/java/org/apache/giraph/TestOutOfCore.java
+++ b/giraph-examples/src/test/java/org/apache/giraph/TestOutOfCore.java
@@ -18,7 +18,6 @@
package org.apache.giraph;
-import org.apache.giraph.comm.netty.NettyClient;
import org.apache.giraph.conf.GiraphConfiguration;
import org.apache.giraph.conf.GiraphConstants;
import org.apache.giraph.examples.GeneratedVertexReader;
@@ -59,7 +58,6 @@ public class TestOutOfCore extends BspCase {
SimplePageRankComputation.SimplePageRankWorkerContext.class);
conf.setMasterComputeClass(
SimplePageRankComputation.SimplePageRankMasterCompute.class);
- GiraphConstants.METRICS_ENABLE.set(conf, true);
GiraphConstants.USER_PARTITION_COUNT.set(conf, NUM_PARTITIONS);
GiraphConstants.USE_OUT_OF_CORE_GRAPH.set(conf, true);
GiraphConstants.MAX_PARTITIONS_IN_MEMORY.set(conf, NUM_PARTITIONS_IN_MEMORY);
@@ -97,7 +95,7 @@ public class TestOutOfCore extends BspCase {
getTempPath(getCallingMethodName()));
// Overwrite the number of vertices set in BspCase
GeneratedVertexReader.READER_VERTICES.set(conf, 200);
- assertTrue(job.run(true));
+ assertTrue(job.run(false));
if (!runningInDistributedMode()) {
double maxPageRank =
SimplePageRankComputation.SimplePageRankWorkerContext.getFinalMax();