[GitHub] [netbeans] sdedic commented on a change in pull request #3129: Eating VSCode own Dog Food

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #3129:
URL: https://github.com/apache/netbeans/pull/3129#discussion_r699258065



##########
File path: platform/autoupdate.cli/src/org/netbeans/modules/autoupdate/cli/ModuleOptions.java
##########
@@ -395,7 +381,11 @@ private void install(final Env env, String... pattern) throws CommandException {
         }
         final InstallSupport support = operate.getSupport();
         if (support == null) {
-            env.getOutputStream().println(Bundle.MSG_InstallNoMatch(Arrays.asList(pats)));
+            if (!found) {
+                sb.insert(0, MSG_CannotFindAnyPattern(cnm));
+                throw new CommandException(55, sb.toString());

Review comment:
       This exitcode should be documented somehow.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists