You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/27 07:26:30 UTC
Review Request 46725: Set default Content-Type for HTTP responses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46725/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Bugs: MESOS-3739
https://issues.apache.org/jira/browse/MESOS-3739
Repository: mesos
Description
-------
The default Content-Type for HTTP responses that contain body is set
as "text/plain; charset=utf-8."
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297
3rdparty/libprocess/src/tests/encoder_tests.cpp 61ec8d8722245179a929e954e6338606973b819b
Diff: https://reviews.apache.org/r/46725/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46725: Set default Content-Type for HTTP responses.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46725/#review130732
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46725]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 27, 2016, 5:26 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46725/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 5:26 a.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Bugs: MESOS-3739
> https://issues.apache.org/jira/browse/MESOS-3739
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The default Content-Type for HTTP responses that contain body is set
> as "text/plain; charset=utf-8."
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 61ec8d8722245179a929e954e6338606973b819b
>
> Diff: https://reviews.apache.org/r/46725/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 46725: Set default Content-Type for HTTP responses.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46725/#review130867
-----------------------------------------------------------
Fix it, then Ship it!
LGTM, just 2 minor nits.
Also, as per our offline discussion: This doesn't handle scenarios where a client explicitly expects a error response encoded in a particular type specified via the `Accept` header. We would ideally want to file a JIRA issue and revisit it later once MESOS-4548 is resolved.
3rdparty/libprocess/include/process/http.hpp (line 435)
<https://reviews.apache.org/r/46725/#comment194772>
It seems weird that other places in the file use camel case nomenculture. Can we use `contentType` here to be consistent?
3rdparty/libprocess/src/tests/encoder_tests.cpp (line 65)
<https://reviews.apache.org/r/46725/#comment194773>
Nit: 4 space indent.
- Anand Mazumdar
On April 27, 2016, 5:26 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46725/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 5:26 a.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Bugs: MESOS-3739
> https://issues.apache.org/jira/browse/MESOS-3739
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The default Content-Type for HTTP responses that contain body is set
> as "text/plain; charset=utf-8."
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 61ec8d8722245179a929e954e6338606973b819b
>
> Diff: https://reviews.apache.org/r/46725/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>