You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "laywin (via GitHub)" <gi...@apache.org> on 2024/10/24 11:11:18 UTC
[PR] bugfix: fix npe for nacos registry when look up address [incubator-seata]
laywin opened a new pull request, #6947:
URL: https://github.com/apache/incubator-seata/pull/6947
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
fix: https://github.com/apache/incubator-seata/issues/6940
the problem come from https://github.com/apache/incubator-seata/pull/6797, when look up address, record transactionServiceGroup, but nacos missed the operation.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix npe for nacos registry when look up address [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6947:
URL: https://github.com/apache/incubator-seata/pull/6947#issuecomment-2435016801
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 52.68%. Comparing base [(`0b9d7c9`)](https://app.codecov.io/gh/apache/incubator-seata/commit/0b9d7c9a4972e0674a4da681ee9e7d3a6a194e92?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`16025d2`)](https://app.codecov.io/gh/apache/incubator-seata/commit/16025d2e62eb91d428f2bf91c9765732c2f4474b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...overy/registry/nacos/NacosRegistryServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?src=pr&el=tree&filepath=discovery%2Fseata-discovery-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2Fnacos%2FNacosRegistryServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvZGlzY292ZXJ5L3JlZ2lzdHJ5L25hY29zL05hY29zUmVnaXN0cnlTZXJ2aWNlSW1wbC5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6947 +/- ##
============================================
- Coverage 52.68% 52.68% -0.01%
- Complexity 6557 6558 +1
============================================
Files 1122 1122
Lines 39863 39864 +1
Branches 4667 4667
============================================
- Hits 21002 21001 -1
+ Misses 16865 16864 -1
- Partials 1996 1999 +3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...overy/registry/nacos/NacosRegistryServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6947?src=pr&el=tree&filepath=discovery%2Fseata-discovery-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fdiscovery%2Fregistry%2Fnacos%2FNacosRegistryServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGlzY292ZXJ5L3NlYXRhLWRpc2NvdmVyeS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvZGlzY292ZXJ5L3JlZ2lzdHJ5L25hY29zL05hY29zUmVnaXN0cnlTZXJ2aWNlSW1wbC5qYXZh) | `15.18% <0.00%> (-0.10%)` | :arrow_down: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6947/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix npe for nacos registry when look up address [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi merged PR #6947:
URL: https://github.com/apache/incubator-seata/pull/6947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org