[GitHub] [incubator-datasketches-java] davecromberge edited a comment on pull request #319: Tuple theta extension

[GitBox <gi...@apache.org>]

davecromberge edited a comment on pull request #319:
URL: https://github.com/apache/incubator-datasketches-java/pull/319#issuecomment-639373396


   > I discussed it with my colleagues and we agree with your suggestion to throw exceptions on null inputs when they could change the state of the sketch, or no meaningful result can be returned. If a null has no impact then it will just be ignored.
   > 
   > Thank you, your feedback helped us resolve what to do here!
   
   I'm glad I could provide feedback, it sounds like a sensible approach in the end.  
   
   How do you know when a null would have an effect or not?  Does it depend on the current state of the operation (i.e. `IsEmpty` or `IsFirstCall`) or is it dependent on the method that is being called, such as the stateless ANotB?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org