You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2008/10/28 12:04:44 UTC

[jira] Created: (LUCENE-1429) close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true

close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true
---------------------------------------------------------------------------------------------

                 Key: LUCENE-1429
                 URL: https://issues.apache.org/jira/browse/LUCENE-1429
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 2.4, 2.3.2, 2.3.1, 2.3
            Reporter: Michael McCandless
            Assignee: Michael McCandless
            Priority: Minor
             Fix For: 2.9


Spinoff from http://www.nabble.com/IllegalStateEx-thrown-when-calling-close-to20201825.html

When IndexWriter hits an OOME, it records this and then if close() is
called it calls rollback() instead.  This is a defensive measure, in
case the OOME corrupted the internal buffered state (added/deleted
docs).

But there's a bug: if you opened IndexWriter with autoCommit true,
close() then incorrectly throws an IllegalStatException.

This fix is simple: allow rollback to be called even if autoCommit is
true, internally during close.  (External calls to rollback with
autoCommmit true is still not allowed).


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1429) close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true

Posted by "Jed Wesley-Smith (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643360#action_12643360 ] 

Jed Wesley-Smith commented on LUCENE-1429:
------------------------------------------

Thanks Michael, I'll try and work out the best policy for the client code that should notice OOME and react appropriately.

> close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1429
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1429
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3, 2.3.1, 2.3.2, 2.4
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>
> Spinoff from http://www.nabble.com/IllegalStateEx-thrown-when-calling-close-to20201825.html
> When IndexWriter hits an OOME, it records this and then if close() is
> called it calls rollback() instead.  This is a defensive measure, in
> case the OOME corrupted the internal buffered state (added/deleted
> docs).
> But there's a bug: if you opened IndexWriter with autoCommit true,
> close() then incorrectly throws an IllegalStatException.
> This fix is simple: allow rollback to be called even if autoCommit is
> true, internally during close.  (External calls to rollback with
> autoCommmit true is still not allowed).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1429) close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1429.
----------------------------------------

    Resolution: Fixed

Thanks Jed!

> close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1429
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1429
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3, 2.3.1, 2.3.2, 2.4
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>
> Spinoff from http://www.nabble.com/IllegalStateEx-thrown-when-calling-close-to20201825.html
> When IndexWriter hits an OOME, it records this and then if close() is
> called it calls rollback() instead.  This is a defensive measure, in
> case the OOME corrupted the internal buffered state (added/deleted
> docs).
> But there's a bug: if you opened IndexWriter with autoCommit true,
> close() then incorrectly throws an IllegalStatException.
> This fix is simple: allow rollback to be called even if autoCommit is
> true, internally during close.  (External calls to rollback with
> autoCommmit true is still not allowed).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1429) close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1429.
----------------------------------------

    Resolution: Fixed

Committed revision 745788 on 2.4 branch.

> close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1429
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1429
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3, 2.3.1, 2.3.2, 2.4
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4.1, 2.9
>
>
> Spinoff from http://www.nabble.com/IllegalStateEx-thrown-when-calling-close-to20201825.html
> When IndexWriter hits an OOME, it records this and then if close() is
> called it calls rollback() instead.  This is a defensive measure, in
> case the OOME corrupted the internal buffered state (added/deleted
> docs).
> But there's a bug: if you opened IndexWriter with autoCommit true,
> close() then incorrectly throws an IllegalStatException.
> This fix is simple: allow rollback to be called even if autoCommit is
> true, internally during close.  (External calls to rollback with
> autoCommmit true is still not allowed).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1429) close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-1429:
---------------------------------------

    Fix Version/s: 2.4.1

> close() throws incorrect IllegalStateEx after IndexWriter hit an OOME when autoCommit is true
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1429
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1429
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3, 2.3.1, 2.3.2, 2.4
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4.1, 2.9
>
>
> Spinoff from http://www.nabble.com/IllegalStateEx-thrown-when-calling-close-to20201825.html
> When IndexWriter hits an OOME, it records this and then if close() is
> called it calls rollback() instead.  This is a defensive measure, in
> case the OOME corrupted the internal buffered state (added/deleted
> docs).
> But there's a bug: if you opened IndexWriter with autoCommit true,
> close() then incorrectly throws an IllegalStatException.
> This fix is simple: allow rollback to be called even if autoCommit is
> true, internally during close.  (External calls to rollback with
> autoCommmit true is still not allowed).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org