You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "marcosschroh (via GitHub)" <gi...@apache.org> on 2024/02/28 14:11:25 UTC
[PR] AVRO-3950: [Rust] tests added for match_schemas in schema_compatibility [avro]
marcosschroh opened a new pull request, #2773:
URL: https://github.com/apache/avro/pull/2773
## What is the purpose of the change
This pull request add tests for `match_schemas` in schema_compatibility `AVRO-3950`
## Verifying this change
- This change is a trivial rework / code cleanup without any test coverage.
- Added test that validates `match_schemas
- This PR also shows that some code is never called in the funcion `match_schemas` as pointed in [AVRO-3950](https://issues.apache.org/jira/browse/AVRO-3950)
- This PR also shows that `nanos` types implementation are missing in [schema parse_complex](https://github.com/apache/avro/blob/main/lang/rust/avro/src/schema.rs#L1387), which is also not documented in the [avro spec](https://avro.apache.org/docs/1.11.1/specification/#logical-types)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3950: [Rust] tests added for match_schemas in schema_compatibility [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2773:
URL: https://github.com/apache/avro/pull/2773#issuecomment-1969148379
> * This PR also shows that `nanos` types implementation are missing in [schema parse_complex](https://github.com/apache/avro/blob/main/lang/rust/avro/src/schema.rs#L1387), which is also not documented in the [avro spec](https://avro.apache.org/docs/1.11.1/specification/#logical-types)
`(local-)timestamp-nanos` is new! It will be part of the next release that's why it is not in the spec for 1.11.1 (last deployed docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3950: [Rust] tests added for match_schemas in schema_compatibility [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2773:
URL: https://github.com/apache/avro/pull/2773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3950: [Rust] tests added for match_schemas in schema_compatibility [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2773:
URL: https://github.com/apache/avro/pull/2773#issuecomment-1970479862
Thank you, @marcosschroh !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org